public inbox for linux-fsdevel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joanne Koong <joannelkoong@gmail.com>
To: miklos@szeredi.hu, linux-fsdevel@vger.kernel.org
Cc: josef@toxicpanda.com, bernd.schubert@fastmail.fm,
	jefflexu@linux.alibaba.com, willy@infradead.org,
	shakeel.butt@linux.dev, kernel-team@meta.com
Subject: [PATCH 02/12] fuse: support large folios for retrieves
Date: Fri,  8 Nov 2024 16:12:48 -0800	[thread overview]
Message-ID: <20241109001258.2216604-3-joannelkoong@gmail.com> (raw)
In-Reply-To: <20241109001258.2216604-1-joannelkoong@gmail.com>

Add support for folios larger than one page size for retrieves.

Signed-off-by: Joanne Koong <joannelkoong@gmail.com>
---
 fs/fuse/dev.c | 25 +++++++++++++++----------
 1 file changed, 15 insertions(+), 10 deletions(-)

diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c
index 9914cc1243f4..5be666af3ebe 100644
--- a/fs/fuse/dev.c
+++ b/fs/fuse/dev.c
@@ -1719,7 +1719,7 @@ static int fuse_retrieve(struct fuse_mount *fm, struct inode *inode,
 	unsigned int num;
 	unsigned int offset;
 	size_t total_len = 0;
-	unsigned int num_pages, cur_pages = 0;
+	unsigned int num_pages;
 	struct fuse_conn *fc = fm->fc;
 	struct fuse_retrieve_args *ra;
 	size_t args_size = sizeof(*ra);
@@ -1737,6 +1737,7 @@ static int fuse_retrieve(struct fuse_mount *fm, struct inode *inode,
 
 	num_pages = (num + offset + PAGE_SIZE - 1) >> PAGE_SHIFT;
 	num_pages = min(num_pages, fc->max_pages);
+	num = min(num, num_pages << PAGE_SHIFT);
 
 	args_size += num_pages * (sizeof(ap->folios[0]) + sizeof(ap->descs[0]));
 
@@ -1757,25 +1758,29 @@ static int fuse_retrieve(struct fuse_mount *fm, struct inode *inode,
 
 	index = outarg->offset >> PAGE_SHIFT;
 
-	while (num && cur_pages < num_pages) {
+	while (num) {
 		struct folio *folio;
-		unsigned int this_num;
+		unsigned int folio_offset;
+		unsigned int nr_bytes;
+		unsigned int nr_pages;
 
 		folio = filemap_get_folio(mapping, index);
 		if (IS_ERR(folio))
 			break;
 
-		this_num = min_t(unsigned, num, PAGE_SIZE - offset);
+		folio_offset = ((index - folio->index) << PAGE_SHIFT) + offset;
+		nr_bytes = min(folio_size(folio) - folio_offset, num);
+		nr_pages = (offset + nr_bytes + PAGE_SIZE - 1) >> PAGE_SHIFT;
+
 		ap->folios[ap->num_folios] = folio;
-		ap->descs[ap->num_folios].offset = offset;
-		ap->descs[ap->num_folios].length = this_num;
+		ap->descs[ap->num_folios].offset = folio_offset;
+		ap->descs[ap->num_folios].length = nr_bytes;
 		ap->num_folios++;
-		cur_pages++;
 
 		offset = 0;
-		num -= this_num;
-		total_len += this_num;
-		index++;
+		num -= nr_bytes;
+		total_len += nr_bytes;
+		index += nr_pages;
 	}
 	ra->inarg.offset = outarg->offset;
 	ra->inarg.size = total_len;
-- 
2.43.5


  parent reply	other threads:[~2024-11-09  0:13 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-09  0:12 [PATCH 00/12] fuse: support large folios Joanne Koong
2024-11-09  0:12 ` [PATCH 01/12] fuse: support copying " Joanne Koong
2024-11-21 22:27   ` Josef Bacik
2024-11-09  0:12 ` Joanne Koong [this message]
2024-11-21 22:28   ` [PATCH 02/12] fuse: support large folios for retrieves Josef Bacik
2024-11-09  0:12 ` [PATCH 03/12] fuse: refactor fuse_fill_write_pages() Joanne Koong
2024-11-21 22:28   ` Josef Bacik
2024-11-09  0:12 ` [PATCH 04/12] fuse: support large folios for non-writeback writes Joanne Koong
2024-11-12 17:32   ` Joanne Koong
2024-11-13 18:41     ` Joanne Koong
2024-11-21 22:32   ` Josef Bacik
2024-11-09  0:12 ` [PATCH 05/12] fuse: support large folios for folio reads Joanne Koong
2024-11-22 14:42   ` Josef Bacik
2024-11-09  0:12 ` [PATCH 06/12] fuse: support large folios for symlinks Joanne Koong
2024-11-22 14:43   ` Josef Bacik
2024-11-09  0:12 ` [PATCH 07/12] fuse: support large folios for stores Joanne Koong
2024-11-22 14:45   ` Josef Bacik
2024-11-09  0:12 ` [PATCH 08/12] fuse: support large folios for queued writes Joanne Koong
2024-11-22 14:45   ` Josef Bacik
2024-11-09  0:12 ` [PATCH 09/12] fuse: support large folios for readahead Joanne Koong
2024-11-22 14:47   ` Josef Bacik
2024-11-25 19:23     ` Joanne Koong
2024-11-09  0:12 ` [PATCH 10/12] fuse: support large folios for direct io Joanne Koong
2024-11-22 14:49   ` Josef Bacik
2024-11-09  0:12 ` [PATCH 11/12] fuse: support large folios for writeback Joanne Koong
2024-11-22 14:50   ` Josef Bacik
2024-11-09  0:12 ` [PATCH 12/12] fuse: enable large folios Joanne Koong
2024-11-22 14:51   ` Josef Bacik
2024-11-09  0:22 ` [PATCH 00/12] fuse: support " Joanne Koong
2024-11-09  0:32   ` Bernd Schubert
2024-11-11 17:44     ` Joanne Koong
2024-11-13 18:58   ` Joanne Koong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241109001258.2216604-3-joannelkoong@gmail.com \
    --to=joannelkoong@gmail.com \
    --cc=bernd.schubert@fastmail.fm \
    --cc=jefflexu@linux.alibaba.com \
    --cc=josef@toxicpanda.com \
    --cc=kernel-team@meta.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=shakeel.butt@linux.dev \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox