Re: [PATCH 0/4] Add the ability to query mount options in statmount

[Josef Bacik <josef@toxicpanda.com>]

On Mon, Nov 11, 2024 at 02:12:16PM +0100, Miklos Szeredi wrote:
> On Wed, 26 Jun 2024 at 14:23, Miklos Szeredi <miklos@szeredi.hu> wrote:
> >
> > On Tue, 25 Jun 2024 at 16:18, Josef Bacik <josef@toxicpanda.com> wrote:
> >
> > > But that means getting the buffer, and going back through it and replacing every
> > > ',' with a '\0', because I'm sure as hell not going and changing all of our
> > > ->show_options() callbacks to not put in a ','.
> > >
> > > Is this the direction we want to go?
> >
> > IMO yes.  Having a clean interface is much more important than doing
> > slightly less processing on the kernel side (which would likely be
> > done anyway on the user side).
> 
> So I went for an extended leave, and this interface was merged in the
> meantime with much to be desired.
> 
> The options are presented just the same as in /proc/self/mountinfo
> (just the standard options left out).  And that has all the same
> problems:
> 
>  - options can't contain commas (this causes much headache for
> overlayfs which has filenames in its options)
> 
>  - to allow the result to be consumed by fsconfig() for example
> options need to be unescaped
> 
>  - mnt_opts is confusing, since these are *not* mount options, these
> are super block options.
> 
> This patchset was apparently hurried through without much thought and
> review, and what review I did provide was ignored.  So I'm
> frustrated, but not sure what if anything can be done at this point,
> since the interface went live in the last release and changing it
> would probably break things...

My apologies Miklos, I value your opinion and your feedback.  Sending my mind
back to when we were discussing this I think it just got lost in the other
patchsets I was working on, and then it got merged so it was "ok that's done,
next thing."  That's my bad, I'll be more careful in the future.  Thanks,

Josef