* [PATCH] dquot.c: get rid of include ../internal.h
@ 2024-11-12 21:38 Al Viro
2024-11-13 14:25 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Al Viro @ 2024-11-12 21:38 UTC (permalink / raw)
To: linux-fsdevel; +Cc: Jan Kara
Ugh, indeed - and not needed nearly a decade. It had been
added for the sake of inode_sb_list_lock and that spinlock had become
a per-superblock (->s_inode_list_lock) in March 2015...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
fs/quota/dquot.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c
index b40410cd39af..3dd8d6f27725 100644
--- a/fs/quota/dquot.c
+++ b/fs/quota/dquot.c
@@ -80,7 +80,6 @@
#include <linux/quotaops.h>
#include <linux/blkdev.h>
#include <linux/sched/mm.h>
-#include "../internal.h" /* ugh */
#include <linux/uaccess.h>
--
2.39.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dquot.c: get rid of include ../internal.h
2024-11-12 21:38 [PATCH] dquot.c: get rid of include ../internal.h Al Viro
@ 2024-11-13 14:25 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2024-11-13 14:25 UTC (permalink / raw)
To: Al Viro; +Cc: linux-fsdevel, Jan Kara
On Tue 12-11-24 21:38:42, Al Viro wrote:
> Ugh, indeed - and not needed nearly a decade. It had been
> added for the sake of inode_sb_list_lock and that spinlock had become
> a per-superblock (->s_inode_list_lock) in March 2015...
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Thanks! Added to my tree.
Honza
> ---
> fs/quota/dquot.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c
> index b40410cd39af..3dd8d6f27725 100644
> --- a/fs/quota/dquot.c
> +++ b/fs/quota/dquot.c
> @@ -80,7 +80,6 @@
> #include <linux/quotaops.h>
> #include <linux/blkdev.h>
> #include <linux/sched/mm.h>
> -#include "../internal.h" /* ugh */
>
> #include <linux/uaccess.h>
>
> --
> 2.39.5
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-13 14:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-12 21:38 [PATCH] dquot.c: get rid of include ../internal.h Al Viro
2024-11-13 14:25 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox