[PATCH] statx.2: Update STATX_WRITE_ATOMIC filesystem support

[PATCH] statx.2: Update STATX_WRITE_ATOMIC filesystem support

[John Garry]

Linux v6.13 will include atomic write support for xfs and ext4, so update
STATX_WRITE_ATOMIC commentary to mention that.

Signed-off-by: John Garry <john.g.garry@oracle.com>

diff --git a/man/man2/statx.2 b/man/man2/statx.2
index c5b5a28ec..2d33998c5 100644
--- a/man/man2/statx.2
+++ b/man/man2/statx.2
@@ -482,6 +482,15 @@ The minimum and maximum sizes (in bytes) supported for direct I/O
 .RB ( O_DIRECT )
 on the file to be written with torn-write protection.
 These values are each guaranteed to be a power-of-2.
+.IP
+.B STATX_WRITE_ATOMIC
+.RI ( stx_atomic_write_unit_min,
+.RI stx_atomic_write_unit_max,
+and
+.IR stx_atomic_write_segments_max )
+is supported on block devices since Linux 6.11.
+The support on regular files varies by filesystem;
+it is supported by xfs and ext4 since Linux 6.13.
 .TP
 .I stx_atomic_write_segments_max
 The maximum number of elements in an array of vectors
-- 
2.31.1

Re: [PATCH] statx.2: Update STATX_WRITE_ATOMIC filesystem support

[Darrick J. Wong]

On Tue, Dec 03, 2024 at 02:53:59PM +0000, John Garry wrote:
> Linux v6.13 will include atomic write support for xfs and ext4, so update
> STATX_WRITE_ATOMIC commentary to mention that.
> 
> Signed-off-by: John Garry <john.g.garry@oracle.com>
> 
> diff --git a/man/man2/statx.2 b/man/man2/statx.2
> index c5b5a28ec..2d33998c5 100644
> --- a/man/man2/statx.2
> +++ b/man/man2/statx.2
> @@ -482,6 +482,15 @@ The minimum and maximum sizes (in bytes) supported for direct I/O
>  .RB ( O_DIRECT )
>  on the file to be written with torn-write protection.
>  These values are each guaranteed to be a power-of-2.
> +.IP
> +.B STATX_WRITE_ATOMIC
> +.RI ( stx_atomic_write_unit_min,
> +.RI stx_atomic_write_unit_max,
> +and
> +.IR stx_atomic_write_segments_max )
> +is supported on block devices since Linux 6.11.
> +The support on regular files varies by filesystem;
> +it is supported by xfs and ext4 since Linux 6.13.

woot!

Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

>  .TP
>  .I stx_atomic_write_segments_max
>  The maximum number of elements in an array of vectors
> -- 
> 2.31.1
> 

Re: [PATCH] statx.2: Update STATX_WRITE_ATOMIC filesystem support

[Alejandro Colomar]

[-- Attachment #1: Type: text/plain, Size: 1294 bytes --]

Hi John,

On Tue, Dec 03, 2024 at 02:53:59PM +0000, John Garry wrote:
> Linux v6.13 will

Is this already in Linus's tree?

> include atomic write support for xfs and ext4, so update
> STATX_WRITE_ATOMIC commentary to mention that.
> 
> Signed-off-by: John Garry <john.g.garry@oracle.com>

Thanks for the patch!  Please see some small comment below.

Have a lovely night!
Alex

> 
> diff --git a/man/man2/statx.2 b/man/man2/statx.2
> index c5b5a28ec..2d33998c5 100644
> --- a/man/man2/statx.2
> +++ b/man/man2/statx.2
> @@ -482,6 +482,15 @@ The minimum and maximum sizes (in bytes) supported for direct I/O
>  .RB ( O_DIRECT )
>  on the file to be written with torn-write protection.
>  These values are each guaranteed to be a power-of-2.
> +.IP
> +.B STATX_WRITE_ATOMIC
> +.RI ( stx_atomic_write_unit_min,
> +.RI stx_atomic_write_unit_max,

There should be a space before the ','.

> +and
> +.IR stx_atomic_write_segments_max )
> +is supported on block devices since Linux 6.11.
> +The support on regular files varies by filesystem;
> +it is supported by xfs and ext4 since Linux 6.13.
>  .TP
>  .I stx_atomic_write_segments_max
>  The maximum number of elements in an array of vectors
> -- 
> 2.31.1
> 

-- 
<https://www.alejandro-colomar.es/>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] statx.2: Update STATX_WRITE_ATOMIC filesystem support

[John Garry]

On 04/12/2024 20:45, Alejandro Colomar wrote:
> Hi John,
> 
> On Tue, Dec 03, 2024 at 02:53:59PM +0000, John Garry wrote:
>> Linux v6.13 will
> 
> Is this already in Linus's tree?

The code to support xfs and ext4 is in Linus' tree from v6.13-rc1, but 
v6.13 final is not released yet.

So maybe you want to hold off on this patch until v6.13 final is released.

> 
>> include atomic write support for xfs and ext4, so update
>> STATX_WRITE_ATOMIC commentary to mention that.
>>
>> Signed-off-by: John Garry <john.g.garry@oracle.com>
> 
> Thanks for the patch!  Please see some small comment below.
> 
> Have a lovely night!
> Alex
> 
>>
>> diff --git a/man/man2/statx.2 b/man/man2/statx.2
>> index c5b5a28ec..2d33998c5 100644
>> --- a/man/man2/statx.2
>> +++ b/man/man2/statx.2
>> @@ -482,6 +482,15 @@ The minimum and maximum sizes (in bytes) supported for direct I/O
>>   .RB ( O_DIRECT )
>>   on the file to be written with torn-write protection.
>>   These values are each guaranteed to be a power-of-2.
>> +.IP
>> +.B STATX_WRITE_ATOMIC
>> +.RI ( stx_atomic_write_unit_min,
>> +.RI stx_atomic_write_unit_max,
> 
> There should be a space before the ','.
> 
>> +and
>> +.IR stx_atomic_write_segments_max )

How about this:

.B STATX_WRITE_ATOMIC
.RI ( stx_atomic_write_unit_min,
.I stx_atomic_write_unit_max,
and
.IR stx_atomic_write_segments_max )

I think that this looks right.

Thanks,
John

Re: [PATCH] statx.2: Update STATX_WRITE_ATOMIC filesystem support

[Alejandro Colomar]

[-- Attachment #1: Type: text/plain, Size: 1647 bytes --]

Hi John,

On Thu, Dec 05, 2024 at 09:33:18AM +0000, John Garry wrote:
> On 04/12/2024 20:45, Alejandro Colomar wrote:
> > Hi John,
> > 
> > On Tue, Dec 03, 2024 at 02:53:59PM +0000, John Garry wrote:
> > > Linux v6.13 will
> > 
> > Is this already in Linus's tree?
> 
> The code to support xfs and ext4 is in Linus' tree from v6.13-rc1, but v6.13
> final is not released yet.
> 
> So maybe you want to hold off on this patch until v6.13 final is released.

Nah, we can apply it already.  Just let me know if anything changes
before the release.

> > > diff --git a/man/man2/statx.2 b/man/man2/statx.2
> > > index c5b5a28ec..2d33998c5 100644
> > > --- a/man/man2/statx.2
> > > +++ b/man/man2/statx.2
> > > @@ -482,6 +482,15 @@ The minimum and maximum sizes (in bytes) supported for direct I/O
> > >   .RB ( O_DIRECT )
> > >   on the file to be written with torn-write protection.
> > >   These values are each guaranteed to be a power-of-2.
> > > +.IP
> > > +.B STATX_WRITE_ATOMIC
> > > +.RI ( stx_atomic_write_unit_min,
> > > +.RI stx_atomic_write_unit_max,
> > 
> > There should be a space before the ','.
> > 
> > > +and
> > > +.IR stx_atomic_write_segments_max )
> 
> How about this:
> 
> .B STATX_WRITE_ATOMIC
> .RI ( stx_atomic_write_unit_min,
> .I stx_atomic_write_unit_max,
> and
> .IR stx_atomic_write_segments_max )
> 
> I think that this looks right.

No; the comma shouldn't be in italics.

.B STATX_WRITE_ATOMIC
.RI ( stx_atomic_write_unit_min ,
.IR stx_atomic_write_unit_max ,
and
.IR stx_atomic_write_segments_max )


Cheers,
Alex

-- 
<https://www.alejandro-colomar.es/>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] statx.2: Update STATX_WRITE_ATOMIC filesystem support

[John Garry]

On 05/12/2024 10:02, Alejandro Colomar wrote:
> Hi John,
> 
> On Thu, Dec 05, 2024 at 09:33:18AM +0000, John Garry wrote:
>> On 04/12/2024 20:45, Alejandro Colomar wrote:
>>> Hi John,
>>>
>>> On Tue, Dec 03, 2024 at 02:53:59PM +0000, John Garry wrote:
>>>> Linux v6.13 will
>>>
>>> Is this already in Linus's tree?
>>
>> The code to support xfs and ext4 is in Linus' tree from v6.13-rc1, but v6.13
>> final is not released yet.
>>
>> So maybe you want to hold off on this patch until v6.13 final is released.
> 
> Nah, we can apply it already.  Just let me know if anything changes
> before the release.

Hi Alex,

I'd suggest that it is ok to merge this now, but Branden seems to have 
comments...

> 
>>>> diff --git a/man/man2/statx.2 b/man/man2/statx.2
>>>> index c5b5a28ec..2d33998c5 100644
>>>> --- a/man/man2/statx.2
>>>> +++ b/man/man2/statx.2
>>>> @@ -482,6 +482,15 @@ The minimum and maximum sizes (in bytes) supported for direct I/O
>>>>    .RB ( O_DIRECT )
>>>>    on the file to be written with torn-write protection.
>>>>    These values are each guaranteed to be a power-of-2.
>>>> +.IP
>>>> +.B STATX_WRITE_ATOMIC
>>>> +.RI ( stx_atomic_write_unit_min,
>>>> +.RI stx_atomic_write_unit_max,
>>>
>>> There should be a space before the ','.
>>>
>>>> +and
>>>> +.IR stx_atomic_write_segments_max )
>>
>> How about this:
>>
>> .B STATX_WRITE_ATOMIC
>> .RI ( stx_atomic_write_unit_min,
>> .I stx_atomic_write_unit_max,
>> and
>> .IR stx_atomic_write_segments_max )
>>
>> I think that this looks right.
> 
> No; the comma shouldn't be in italics.


Please fix up as you see fit.

> 
> .B STATX_WRITE_ATOMIC
> .RI ( stx_atomic_write_unit_min ,
> .IR stx_atomic_write_unit_max ,
> and
> .IR stx_atomic_write_segments_max )
>


Thanks,
John

Re: [PATCH] statx.2: Update STATX_WRITE_ATOMIC filesystem support

[G. Branden Robinson]

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

Hi John,

At 2024-12-16T10:35:42+0000, John Garry wrote:
> On 05/12/2024 10:02, Alejandro Colomar wrote:
> > On Thu, Dec 05, 2024 at 09:33:18AM +0000, John Garry wrote:
> > Nah, we can apply it already.  Just let me know if anything changes
> > before the release.
> 
> I'd suggest that it is ok to merge this now, but Branden seems to have
> comments...

I don't generally intend my review comments to be gating, and this is no
exception.  (I should try harder to state that explicitly more often.)
Please don't delay on my account.  :)

Regards,
Branden

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] statx.2: Update STATX_WRITE_ATOMIC filesystem support

[Alejandro Colomar]

[-- Attachment #1: Type: text/plain, Size: 885 bytes --]

Hi Branden, John,

On Mon, Dec 16, 2024 at 06:38:53AM -0600, G. Branden Robinson wrote:
> Hi John,
> 
> At 2024-12-16T10:35:42+0000, John Garry wrote:
> > On 05/12/2024 10:02, Alejandro Colomar wrote:
> > > On Thu, Dec 05, 2024 at 09:33:18AM +0000, John Garry wrote:
> > > Nah, we can apply it already.  Just let me know if anything changes
> > > before the release.
> > 
> > I'd suggest that it is ok to merge this now, but Branden seems to have
> > comments...
> 
> I don't generally intend my review comments to be gating, and this is no
> exception.  (I should try harder to state that explicitly more often.)

Nah, I just forgot about this patch.  Thanks for the ping; I'll apply it
later today (if I don't forget again).  :)

Cheers,
Alex

> Please don't delay on my account.  :)
> 
> Regards,
> Branden



-- 
<https://www.alejandro-colomar.es/>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] statx.2: Update STATX_WRITE_ATOMIC filesystem support

[Alejandro Colomar]

[-- Attachment #1: Type: text/plain, Size: 1303 bytes --]

Hi John,

On Mon, Dec 16, 2024 at 01:47:53PM +0100, Alejandro Colomar wrote:
> Hi Branden, John,
> 
> On Mon, Dec 16, 2024 at 06:38:53AM -0600, G. Branden Robinson wrote:
> > Hi John,
> > 
> > At 2024-12-16T10:35:42+0000, John Garry wrote:
> > > On 05/12/2024 10:02, Alejandro Colomar wrote:
> > > > On Thu, Dec 05, 2024 at 09:33:18AM +0000, John Garry wrote:
> > > > Nah, we can apply it already.  Just let me know if anything changes
> > > > before the release.
> > > 
> > > I'd suggest that it is ok to merge this now, but Branden seems to have
> > > comments...
> > 
> > I don't generally intend my review comments to be gating, and this is no
> > exception.  (I should try harder to state that explicitly more often.)
> 
> Nah, I just forgot about this patch.  Thanks for the ping; I'll apply it
> later today (if I don't forget again).  :)

I did forget again.  :)

I have applied the patch now.  Thanks!
<https://www.alejandro-colomar.es/src/alx/linux/man-pages/man-pages.git/commit/?h=contrib&id=e2d3dadf562ac07d086a9732993cb79898bc6b17>


Cheers,
Alex

> 
> Cheers,
> Alex
> 
> > Please don't delay on my account.  :)
> > 
> > Regards,
> > Branden
> 
> 
> 
> -- 
> <https://www.alejandro-colomar.es/>



-- 
<https://www.alejandro-colomar.es/>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]