From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@meta.com>
Cc: axboe@kernel.dk, hch@lst.de, linux-block@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org,
io-uring@vger.kernel.org, sagi@grimberg.me,
asml.silence@gmail.com, anuj20.g@samsung.com,
joshi.k@samsung.com, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCHv12 00/12] block write streams with nvme fdp
Date: Mon, 9 Dec 2024 13:55:11 +0100 [thread overview]
Message-ID: <20241209125511.GB14316@lst.de> (raw)
In-Reply-To: <20241206221801.790690-1-kbusch@meta.com>
I just compared this to a crude rebase of what I last sent out, and
AFAICS the differences are:
1) basically all new io_uring handling due to the integrity stuff that
went in
2) fixes for the NVMe FDP log page parsing
3) drop the support for the remapping of per-partition streams
conceptually this all looks fine to me. I'll throw in a few nitpicks
on the nvme bits, and I'd need to get up to speed a bit more on the
io_uring bits before commenting useful.
One thing that came I was pondering for a new version is if statx
really is the right vehicle for this as it is a very common fast-path
information. If we had a separate streaminfo ioctl or fcntl it might
be easier to leave a bit spare space for extensibility. I can try to
prototype that or we can leave it as-is because everyone is tired of
the series.
next prev parent reply other threads:[~2024-12-09 12:55 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241206221801.790690-1-kbusch@meta.com>
[not found] ` <20241206221801.790690-2-kbusch@meta.com>
2024-12-09 8:25 ` [PATCHv12 01/12] fs: add write stream information to statx Hannes Reinecke
2024-12-09 11:44 ` Nitesh Shetty
[not found] ` <20241206221801.790690-4-kbusch@meta.com>
2024-12-09 8:26 ` [PATCHv12 03/12] block: add a bi_write_stream field Hannes Reinecke
2024-12-10 7:34 ` Nitesh Shetty
[not found] ` <20241206221801.790690-5-kbusch@meta.com>
2024-12-09 8:27 ` [PATCHv12 04/12] block: introduce max_write_streams queue limit Hannes Reinecke
2024-12-10 7:38 ` Nitesh Shetty
[not found] ` <20241206221801.790690-6-kbusch@meta.com>
2024-12-09 8:29 ` [PATCHv12 05/12] block: introduce a write_stream_granularity " Hannes Reinecke
2024-12-10 7:45 ` Nitesh Shetty
[not found] ` <20241206221801.790690-7-kbusch@meta.com>
2024-12-09 8:30 ` [PATCHv12 06/12] block: expose write streams for block device nodes Hannes Reinecke
2024-12-09 10:58 ` Nitesh Shetty
[not found] ` <20241206221801.790690-8-kbusch@meta.com>
2024-12-09 8:31 ` [PATCHv12 07/12] io_uring: enable per-io write streams Hannes Reinecke
[not found] ` <20241206221801.790690-10-kbusch@meta.com>
2024-12-09 8:32 ` [PATCHv12 09/12] nvme: pass a void pointer to nvme_get/set_features for the result Hannes Reinecke
2024-12-10 12:13 ` Nitesh Shetty
[not found] ` <20241206221801.790690-11-kbusch@meta.com>
2024-12-09 8:33 ` [PATCHv12 10/12] nvme.h: add FDP definitions Hannes Reinecke
2024-12-10 12:19 ` Nitesh Shetty
[not found] ` <20241206221801.790690-13-kbusch@meta.com>
2024-12-09 8:34 ` [PATCHv12 12/12] nvme: use fdp streams if write stream is provided Hannes Reinecke
2024-12-10 7:27 ` Nitesh Shetty
[not found] ` <20241206221801.790690-3-kbusch@meta.com>
2024-12-09 8:25 ` [PATCHv12 02/12] fs: add a write stream field to the kiocb Hannes Reinecke
2024-12-09 12:47 ` [PATCHv12 01/12] fs: add write stream information to statx Christian Brauner
2024-12-10 7:24 ` [PATCHv12 02/12] fs: add a write stream field to the kiocb Nitesh Shetty
2024-12-09 12:55 ` Christoph Hellwig [this message]
2024-12-09 16:07 ` [PATCHv12 00/12] block write streams with nvme fdp Keith Busch
2024-12-10 1:49 ` Martin K. Petersen
2024-12-10 7:19 ` Christoph Hellwig
[not found] ` <20241206221801.790690-12-kbusch@meta.com>
2024-12-09 4:05 ` [PATCHv12 11/12] nvme: register fdp parameters with the block layer kernel test robot
2024-12-09 12:44 ` Christoph Hellwig
2024-12-09 8:34 ` Hannes Reinecke
2024-12-09 13:18 ` Christoph Hellwig
2024-12-09 16:29 ` Keith Busch
2024-12-10 8:45 ` Dan Carpenter
2024-12-10 15:23 ` Keith Busch
[not found] ` <20241206221801.790690-9-kbusch@meta.com>
2024-12-09 8:31 ` [PATCHv12 08/12] nvme: add a nvme_get_log_lsi helper Hannes Reinecke
2024-12-10 12:12 ` Nitesh Shetty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241209125511.GB14316@lst.de \
--to=hch@lst.de \
--cc=anuj20.g@samsung.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox