From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10E08215798; Thu, 12 Dec 2024 15:05:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734015957; cv=none; b=cTf4P0Cf6W5oTwJ3QyjH1aoz6nrxMGkof4s0iPdiXLcEi25vpHt/21H00Y5yZNeBYXpZrObA/nY5rAFdv+kaLFwVrZVI6nEvqyM7iDKZKt/oX/kqJVZ9j1QxeLpJb6Q195Hw0xv+4iCWQRRd0Ht5zxbfnyyLFLsPFt5SsCCV8mU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734015957; c=relaxed/simple; bh=kDVK3QoZssEv2WHeoXiqfbtLHZAC0V1XffADmHviHvg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MYFw8KvSB2oVPFdNITF2/bZe0BUvpOkJxS4XBWBIC6rOzPa+yCvMW8izS28mUy0b+l+bpmTsoMXV8fCKuzFZ7FXFl3oqBJiKWQAuXvb5g1gxd/vVQNr+9toEZ+tHyJD8XuDdhRRlF1AOyY4iEEANHPyOCK1+PPTTK7aj5jP2hk4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 3F9DB68D32; Thu, 12 Dec 2024 16:05:51 +0100 (CET) Date: Thu, 12 Dec 2024 16:05:51 +0100 From: Christoph Hellwig To: Brian Foster Cc: Christoph Hellwig , Christian Brauner , "Darrick J. Wong" , Carlos Maiolino , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 4/8] iomap: split bios to zone append limits in the submission handlers Message-ID: <20241212150551.GA6840@lst.de> References: <20241211085420.1380396-1-hch@lst.de> <20241211085420.1380396-5-hch@lst.de> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) On Thu, Dec 12, 2024 at 08:28:17AM -0500, Brian Foster wrote: > It might be useful to add a small comment here to point out this splits > from the front of the ioend (i.e. akin to bio_split()), documents the > params, and maybe mentions the ioend relationship requirements (i.e. > according to bio_split(), the split ioend bio refers to the vectors in > the original ioend bio). Sure, I can add that.