[PATCH] samples/vfs: add __SANE_USERSPACE_TYPES__ to mountinfo program

[PATCH] samples/vfs: add __SANE_USERSPACE_TYPES__ to mountinfo program

[Jeff Layton]

mountinfo.c is throwing compiler warnings on ppc64. The comment over
__SANE_USERSPACE_TYPES__ says:

 * This is here because we used to use l64 for 64bit powerpc
 * and we don't want to impact user mode with our change to ll64
 * in the kernel.
 *
 * However, some user programs are fine with this.  They can
 * flag __SANE_USERSPACE_TYPES__ to get int-ll64.h here.

That is the case with mountinfo.c, so define it.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Closes: https://lore.kernel.org/all/20241211143701.5cfc95a7@canb.auug.org.au/
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
Feel free to fold this into an earlier patch if that's easier. Also, I
wonder if samples/vfs/test-list-all-mounts.c needs similar treatment?
---
 samples/vfs/mountinfo.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/samples/vfs/mountinfo.c b/samples/vfs/mountinfo.c
index 349aaade4de53912b96eadb35bf1b7457b4b04fa..2b17d244d321ee759543cefa3c9e84e7cd489c9a 100644
--- a/samples/vfs/mountinfo.c
+++ b/samples/vfs/mountinfo.c
@@ -5,6 +5,7 @@
  * contents of /proc/self/mountinfo.
  */
 #define _GNU_SOURCE
+#define __SANE_USERSPACE_TYPES__
 #include <stdio.h>
 #include <stdint.h>
 #include <sys/ioctl.h>

---
base-commit: ef5bbd2a286805b0f97b5fa8616d28a84336ee7b
change-id: 20241219-statmount-002351a3aa68

Best regards,
-- 
Jeff Layton <jlayton@kernel.org>

Re: [PATCH] samples/vfs: add __SANE_USERSPACE_TYPES__ to mountinfo program

[Christian Brauner]

On Thu, 19 Dec 2024 17:11:40 -0500, Jeff Layton wrote:
> mountinfo.c is throwing compiler warnings on ppc64. The comment over
> __SANE_USERSPACE_TYPES__ says:
> 
>  * This is here because we used to use l64 for 64bit powerpc
>  * and we don't want to impact user mode with our change to ll64
>  * in the kernel.
>  *
>  * However, some user programs are fine with this.  They can
>  * flag __SANE_USERSPACE_TYPES__ to get int-ll64.h here.
> 
> [...]

Thanks! Folded into the patch that added the mountinfo program.

Please also note that I moved the series of which this was part from
vfs-6.14.misc to vfs-6.14.mount as it makes a lot more sense there.

---

Applied to the vfs-61.14.mount branch of the vfs/vfs.git tree.
Patches in the vfs-61.14.mount branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-61.14.mount

[1/1] samples/vfs: add __SANE_USERSPACE_TYPES__ to mountinfo program
      (no commit info)