From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D639F1DFF8 for ; Sun, 22 Dec 2024 19:19:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734895155; cv=none; b=GBNqsGj9Dt4hBPQ3ym8CqbQtAlSZsqwSpVAo4dj5igmKuGof/xzQa0VotkmcDzr4YV9t6yjK1K3mGxqBhJlT9S1txt73nGCQxFS4jrli4KsmNxlED7JkTck2mAnCQjvXITn7+O91fpcGqJWhftx6UH6cLkd/owwoKH1w73ao/S0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734895155; c=relaxed/simple; bh=3fYwNzIBWKbEuxRCKjXnKf6+QLQCZIJ7U4RHQamSGUY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lLFAGc+bdI8UsLSTauJqwNKhfrh+9BIXxVmNFNIoIfSurkoCn6wl/CMbdm5WfS9me3zXkzWx2FNmyFnZq7Wq6NxxFViF1tQv43MHLTc5coX9IE43AkhJWr3fQXfIB2KHq+29upiMrQsxZAUkiqrFAszEavcv5A9AwDWi1fcQdao= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=OxjY5uLP; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OxjY5uLP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734895152; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3fYwNzIBWKbEuxRCKjXnKf6+QLQCZIJ7U4RHQamSGUY=; b=OxjY5uLPt9BTGTTrrLM7dU45kdenvG5Z4cGpRn5MNF4gdYf81G3KBH1gmVXh60D1e0T0Uf gFk4JSHwwara6krA+EweyIAERAa4gZ2kP/RRHmk3VQ9b6Tq2luZq2xn2QYGq2EOjtIpkmG OLsvChvPCbS68hvpIfzOw9LRaUM8664= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-125-M0dHsuhIMK6xe8Bd2aO7gg-1; Sun, 22 Dec 2024 14:19:09 -0500 X-MC-Unique: M0dHsuhIMK6xe8Bd2aO7gg-1 X-Mimecast-MFC-AGG-ID: M0dHsuhIMK6xe8Bd2aO7gg Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5DA5719560AA; Sun, 22 Dec 2024 19:19:07 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.224.16]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 535C83000197; Sun, 22 Dec 2024 19:19:02 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Sun, 22 Dec 2024 20:18:43 +0100 (CET) Date: Sun, 22 Dec 2024 20:18:37 +0100 From: Oleg Nesterov To: Nam Cao Cc: Shuah Khan , Andrew Morton , Dylan Hatch , "Eric W . Biederman" , John Ogness , Kees Cook , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/2] fs/proc: do_task_stat: Fix ESP not readable during coredump Message-ID: <20241222191837.GA4224@redhat.com> References: <11e1777296b7d06085c9fd341bafc4b9d82e6e4e.1730883229.git.namcao@linutronix.de> <20241217145923.GA29091@redhat.com> <20241217150913.GB29091@redhat.com> <20241220145326.Q7Z6NQ7j@linutronix.de> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241220145326.Q7Z6NQ7j@linutronix.de> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Hi Nam, On 12/20, Nam Cao wrote: > > > Can't the trivial patch below fix the problem? > > It can. In fact this is the original fix we had. I thought that checking a > single "core_state" is simpler than checking 3 flags, oh well.. > > Can you send a proper patch, or should I do it? Can you send V2 please? It was you who found/investigated the problem, and the patch is trivial. Feel free to include my acked-by. Thanks, Oleg.