From: Al Viro <viro@zeniv.linux.org.uk>
To: Jaroslav Kysela <perex@perex.cz>
Cc: linux-fsdevel@vger.kernel.org,
"Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>,
"Takashi Iwai" <tiwai@suse.de>,
linux-sound@vger.kernel.org, "Vinod Koul" <vkoul@kernel.org>
Subject: Re: [CFT][PATCH] fix descriptor uses in sound/core/compress_offload.c
Date: Thu, 26 Dec 2024 21:31:22 +0000 [thread overview]
Message-ID: <20241226213122.GV1977892@ZenIV> (raw)
In-Reply-To: <d01e06bf-9cbc-4c0e-bcce-2b10b1d04971@perex.cz>
On Thu, Dec 26, 2024 at 08:00:18PM +0100, Jaroslav Kysela wrote:
> I already made almost similar patch:
>
> https://lore.kernel.org/linux-sound/20241217100726.732863-1-perex@perex.cz/
Umm... The only problem with your variant is that dma_buf_get()
is wrong here - it should be get_dma_buf() on actual objects,
and it should be done before fd_install().
next prev parent reply other threads:[~2024-12-26 21:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-26 18:29 [CFT][PATCH] fix descriptor uses in sound/core/compress_offload.c Al Viro
2024-12-26 19:00 ` Jaroslav Kysela
2024-12-26 21:31 ` Al Viro [this message]
2024-12-26 22:17 ` Al Viro
2024-12-29 8:35 ` Takashi Iwai
2024-12-29 18:53 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241226213122.GV1977892@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox