From: Al Viro <viro@zeniv.linux.org.uk>
To: linux-fsdevel@vger.kernel.org
Cc: gregkh@linuxfoundation.org
Subject: Re: [PATCH 20/20] saner replacement for debugfs_rename()
Date: Sun, 29 Dec 2024 16:38:32 +0000 [thread overview]
Message-ID: <20241229163832.GZ1977892@ZenIV> (raw)
In-Reply-To: <20241229081223.3193228-20-viro@zeniv.linux.org.uk>
On Sun, Dec 29, 2024 at 08:12:23AM +0000, Al Viro wrote:
> diff --git a/drivers/net/bonding/bond_debugfs.c b/drivers/net/bonding/bond_debugfs.c
> index b19492a7f6ad..2b78be129770 100644
> --- a/drivers/net/bonding/bond_debugfs.c
> +++ b/drivers/net/bonding/bond_debugfs.c
> @@ -63,13 +63,8 @@ void bond_debug_unregister(struct bonding *bond)
>
> void bond_debug_reregister(struct bonding *bond)
> {
> - struct dentry *d;
> -
> - d = debugfs_rename(bonding_debug_root, bond->debug_dir,
> - bonding_debug_root, bond->dev->name);
> - if (!IS_ERR(d)) {
> - bond->debug_dir = d;
> - } else {
> + err = debugfs_change_name(bond->debug_dir, "%s", bond->dev->name);
That should be
+ int err = debugfs_change_name(bond->debug_dir, "%s", bond->dev->name);
obviously...
next prev parent reply other threads:[~2024-12-29 16:38 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-29 8:09 [PATCHES][RFC][CFT] debugfs cleanups Al Viro
2024-12-29 8:12 ` [PATCH 01/20] debugfs: fix missing mutex_destroy() in short_fops case Al Viro
2024-12-29 8:12 ` [PATCH 02/20] debugfs: separate cache for debugfs inodes Al Viro
2024-12-29 8:12 ` [PATCH 03/20] debugfs: move ->automount into debugfs_inode_info Al Viro
2024-12-29 8:12 ` [PATCH 04/20] debugfs: get rid of dynamically allocation proxy_ops Al Viro
2024-12-29 8:12 ` [PATCH 05/20] debugfs: don't mess with bits in ->d_fsdata Al Viro
2024-12-29 8:12 ` [PATCH 06/20] debugfs: allow to store an additional opaque pointer at file creation Al Viro
2024-12-29 8:12 ` [PATCH 07/20] carl9170: stop embedding file_operations into their objects Al Viro
2024-12-29 8:12 ` [PATCH 08/20] b43: stop embedding struct " Al Viro
2024-12-29 8:12 ` [PATCH 09/20] b43legacy: make use of debugfs_get_aux() Al Viro
2024-12-29 8:12 ` [PATCH 10/20] netdevsim: don't embed file_operations into your structs Al Viro
2024-12-29 8:12 ` [PATCH 11/20] mediatek: stop messing with ->d_iname Al Viro
2024-12-29 8:12 ` [PATCH 12/20] [not even compile-tested] greybus/camera - " Al Viro
2024-12-29 8:12 ` [PATCH 13/20] mtu3: don't mess wiht ->d_iname Al Viro
2024-12-29 8:12 ` [PATCH 14/20] xhci: don't mess with ->d_iname Al Viro
2024-12-29 8:12 ` [PATCH 15/20] qat: don't mess with ->d_name Al Viro
2024-12-29 8:12 ` [PATCH 16/20] sof-client-ipc-flood-test: " Al Viro
2024-12-29 8:12 ` [PATCH 17/20] slub: " Al Viro
2024-12-29 8:12 ` [PATCH 18/20] arm_scmi: don't mess with ->d_parent->d_name Al Viro
2024-12-29 8:12 ` [PATCH 19/20] octeontx2: don't mess with ->d_parent or ->d_parent->d_name Al Viro
2024-12-29 8:12 ` [PATCH 20/20] saner replacement for debugfs_rename() Al Viro
2024-12-29 16:38 ` Al Viro [this message]
2025-01-07 15:20 ` [PATCH 01/20] debugfs: fix missing mutex_destroy() in short_fops case Greg KH
2024-12-29 20:58 ` [PATCHES][RFC][CFT] debugfs cleanups Al Viro
2025-01-07 14:56 ` Greg KH
2025-01-12 8:05 ` [PATCHES v2][RFC][CFT] " Al Viro
2025-01-12 8:06 ` [PATCH v2 01/21] debugfs: separate cache for debugfs inodes Al Viro
2025-01-12 8:06 ` [PATCH v2 02/21] debugfs: move ->automount into debugfs_inode_info Al Viro
2025-01-13 14:49 ` Christian Brauner
2025-01-12 8:06 ` [PATCH v2 03/21] debugfs: get rid of dynamically allocation proxy_ops Al Viro
2025-01-13 14:51 ` Christian Brauner
2025-01-12 8:06 ` [PATCH v2 04/21] debugfs: don't mess with bits in ->d_fsdata Al Viro
2025-01-13 14:55 ` Christian Brauner
2025-01-12 8:06 ` [PATCH v2 05/21] debugfs: allow to store an additional opaque pointer at file creation Al Viro
2025-01-13 14:56 ` Christian Brauner
2025-01-12 8:06 ` [PATCH v2 06/21] debugfs: take debugfs_short_fops definition out of ifdef Al Viro
2025-01-13 14:57 ` Christian Brauner
2025-01-12 8:06 ` [PATCH v2 07/21] carl9170: stop embedding file_operations into their objects Al Viro
2025-01-12 8:06 ` [PATCH v2 08/21] b43: stop embedding struct " Al Viro
2025-01-12 8:06 ` [PATCH v2 09/21] b43legacy: make use of debugfs_get_aux() Al Viro
2025-01-12 8:06 ` [PATCH v2 10/21] netdevsim: don't embed file_operations into your structs Al Viro
2025-01-12 8:06 ` [PATCH v2 11/21] mediatek: stop messing with ->d_iname Al Viro
2025-01-12 8:06 ` [PATCH v2 12/21] [not even compile-tested] greybus/camera - " Al Viro
2025-01-12 8:06 ` [PATCH v2 13/21] mtu3: don't mess wiht ->d_iname Al Viro
2025-01-12 8:06 ` [PATCH v2 14/21] xhci: don't mess with ->d_iname Al Viro
2025-01-12 8:06 ` [PATCH v2 15/21] qat: don't mess with ->d_name Al Viro
2025-01-12 8:07 ` [PATCH v2 16/21] sof-client-ipc-flood-test: " Al Viro
2025-01-12 8:07 ` [PATCH v2 17/21] slub: " Al Viro
2025-01-12 8:07 ` [PATCH v2 18/21] arm_scmi: don't mess with ->d_parent->d_name Al Viro
2025-01-12 8:07 ` [PATCH v2 19/21] octeontx2: don't mess with ->d_parent or ->d_parent->d_name Al Viro
2025-01-12 8:07 ` [PATCH v2 20/21] orangefs-debugfs: don't mess with ->d_name Al Viro
2025-01-12 8:07 ` [PATCH v2 21/21] saner replacement for debugfs_rename() Al Viro
2025-01-13 14:48 ` [PATCH v2 01/21] debugfs: separate cache for debugfs inodes Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241229163832.GZ1977892@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox