From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Chandan Babu R <chandan.babu@oracle.com>,
Hongbo Li <lihongbo22@huawei.com>,
Ryusuke Konishi <konishi.ryusuke@gmail.com>,
linux-nilfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-xfs@vger.kernel.org, linux-man@vger.kernel.org
Subject: Re: [PATCH] statx.2: document STATX_DIO_READ_ALIGN
Date: Mon, 6 Jan 2025 11:09:46 -0800 [thread overview]
Message-ID: <20250106190946.GF6174@frogsfrogsfrogs> (raw)
In-Reply-To: <20250106180958.GA31325@lst.de>
On Mon, Jan 06, 2025 at 07:09:58PM +0100, Christoph Hellwig wrote:
> On Mon, Jan 06, 2025 at 09:40:07AM -0800, Darrick J. Wong wrote:
> > > +stx_dio_offset_align
> > > +which must be provided by the file system.
> >
> > I can't imagine a filesystem where dio_read_offset > dio_offset makes
> > sense, but why do we need to put that in the manpage?
>
> Well, to be backwards compatible to older userspace the value put into
> stx_dio_offset_align also needs to work for reads. Given that there
> were questions about this in the RFC round I thought I'd mention it.
Ah ok then. :)
With the other formatting nits fixed,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
next prev parent reply other threads:[~2025-01-06 19:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 15:15 add STATX_DIO_READ_ALIGN Christoph Hellwig
2025-01-06 15:15 ` [PATCH 1/4] fs: reformat the statx definition Christoph Hellwig
2025-01-06 16:28 ` Jan Kara
2025-01-06 15:15 ` [PATCH 2/4] fs: add STATX_DIO_READ_ALIGN Christoph Hellwig
2025-01-06 16:32 ` Jan Kara
2025-01-06 16:40 ` Christoph Hellwig
2025-01-06 15:15 ` [PATCH 3/4] xfs: cleanup xfs_vn_getattr Christoph Hellwig
2025-01-06 17:07 ` John Garry
2025-01-06 15:15 ` [PATCH 4/4] xfs: report the correct read/write dio alignment for reflinked inodes Christoph Hellwig
2025-01-06 17:33 ` Darrick J. Wong
2025-01-06 18:37 ` John Garry
2025-01-07 6:10 ` Christoph Hellwig
2025-01-07 7:03 ` Darrick J. Wong
2025-01-07 9:00 ` John Garry
2025-01-06 15:19 ` [PATCH] statx.2: document STATX_DIO_READ_ALIGN Christoph Hellwig
2025-01-06 17:40 ` Darrick J. Wong
2025-01-06 18:09 ` Christoph Hellwig
2025-01-06 19:09 ` Darrick J. Wong [this message]
2025-01-06 22:01 ` Alejandro Colomar
-- strict thread matches above, loose matches on Subject: below --
2025-01-08 8:55 add STATX_DIO_READ_ALIGN v2 Christoph Hellwig
2025-01-08 8:59 ` [PATCH] statx.2: document STATX_DIO_READ_ALIGN Christoph Hellwig
2025-01-08 17:27 ` Darrick J. Wong
2025-01-09 8:31 add STATX_DIO_READ_ALIGN v3 Christoph Hellwig
2025-01-09 8:32 ` [PATCH] statx.2: document STATX_DIO_READ_ALIGN Christoph Hellwig
2025-01-09 13:21 ` Alejandro Colomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250106190946.GF6174@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=brauner@kernel.org \
--cc=chandan.babu@oracle.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=konishi.ryusuke@gmail.com \
--cc=lihongbo22@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox