Re: [PATCH 01/20] debugfs: fix missing mutex_destroy() in short_fops case

[Greg KH <gregkh@linuxfoundation.org>]

On Sun, Dec 29, 2024 at 08:12:04AM +0000, Al Viro wrote:
> we need that in ->real_fops == NULL, ->short_fops != NULL case
> 
> Fixes: 8dc6d81c6b2a "debugfs: add small file operations for most files"
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
>  fs/debugfs/inode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
> index 38a9c7eb97e6..c99a0599c811 100644
> --- a/fs/debugfs/inode.c
> +++ b/fs/debugfs/inode.c
> @@ -229,7 +229,7 @@ static void debugfs_release_dentry(struct dentry *dentry)
>  		return;
>  
>  	/* check it wasn't a dir (no fsdata) or automount (no real_fops) */
> -	if (fsd && fsd->real_fops) {
> +	if (fsd && (fsd->real_fops || fsd->short_fops)) {
>  		WARN_ON(!list_empty(&fsd->cancellations));
>  		mutex_destroy(&fsd->cancellations_mtx);
>  	}
> -- 
> 2.39.5
> 

I've taken this one now as it fixes an issue in -rc1.

thanks,

greg k-h