From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FC171C3BE6; Mon, 13 Jan 2025 19:47:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.89.141.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736797669; cv=none; b=jslcYAJAB+7JbuBhBUR7bNiasZMgx3oW3QsOreBqSGDf/4Cclzftsg4gz5PwIObSOjNWRPFMi3p2N72c03YvcxJM6n6JCpqsza4CWkTqxvoemAQxT/VpzoAbGQrxGaPykbw5nyAHHoIc0E0AkHpamHyfxgcF+NMhMQ2VdIwQAJA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736797669; c=relaxed/simple; bh=Z0O6V++p6h3ibBUVu+D6FDZHIzvMMQREaaD2dV7NhY8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Qyl/tAZ+d2WY3egBPNQ5kn4ZDWC3axAVwIhUCP8dkbcj7rXTO0176OyMlhJh6kBt2asptLoXyCHdol5VtUR0ePPUfxbh0xnq1UMoRrGziKtuy/xi1+v9W5ZMbz/2kkOUEIf0lW2AR4XPu3iL5gk/bkTqlodBfODrljRgEC1x3xQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zeniv.linux.org.uk; spf=none smtp.mailfrom=ftp.linux.org.uk; dkim=pass (2048-bit key) header.d=linux.org.uk header.i=@linux.org.uk header.b=LCy8H8mm; arc=none smtp.client-ip=62.89.141.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zeniv.linux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ftp.linux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linux.org.uk header.i=@linux.org.uk header.b="LCy8H8mm" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/tfPUo2EO2PAFpHSyL8n5WUMBZY0Ez9O+GdUFRQZDug=; b=LCy8H8mmNuUrQvYmf0T58GQmN1 owAyWWzaGL46R2hedjAuzzp5C7N559UXyDXIzbX0/HGurPRFDleoYZMWv1mZreb6aQEdlJKTJeuAQ O67mnbanGT+5vmcx5ReqlgxtWIDh3Po3R2c5i8l4i/BRuRbpj0jINSCsaRv8uUv71JTEzckird+iw +uEYYHQDSCGkhiKtd/NN0bQJV2vzjoCnEMlH9fAtWcavfM8BCeEFPlZO58n/66pMU/42Q+PUX+AQL Bkm7L8BatLEY5NQ2+ydOQ6D4ay7Auds6fMAzBLocSeGoFl2QO8Tz4PwYdMSEk/eoovROGiOMRu7qE rF5GbxXA==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.98 #2 (Red Hat Linux)) id 1tXQPY-0000000113X-2J4k; Mon, 13 Jan 2025 19:47:44 +0000 Date: Mon, 13 Jan 2025 19:47:44 +0000 From: Al Viro To: Christophe Leroy Cc: Christian Brauner , Jan Kara , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] select: Fix unbalanced user_access_end() Message-ID: <20250113194744.GZ1977892@ZenIV> References: Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Al Viro On Mon, Jan 13, 2025 at 09:37:24AM +0100, Christophe Leroy wrote: > While working on implementing user access validation on powerpc > I got the following warnings on a pmac32_defconfig build: > > CC fs/select.o > fs/select.o: warning: objtool: sys_pselect6+0x1bc: redundant UACCESS disable > fs/select.o: warning: objtool: sys_pselect6_time32+0x1bc: redundant UACCESS disable > > On powerpc/32s, user_read_access_begin/end() are no-ops, but the > failure path has a user_access_end() instead of user_read_access_end() > which means an access end without any prior access begin. > > Replace that user_access_end() by user_read_access_end(). ACK.