From: Amir Goldstein <amir73il@gmail.com>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Jeff Layton <jlayton@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: [PATCH] nfsd: map EBUSY for all operations
Date: Mon, 20 Jan 2025 18:20:16 +0100 [thread overview]
Message-ID: <20250120172016.397916-1-amir73il@gmail.com> (raw)
v4 client maps NFS4ERR_FILE_OPEN => EBUSY for all operations.
v4 server only maps EBUSY => NFS4ERR_FILE_OPEN for rmdir()/unlink()
although it is also possible to get EBUSY from rename() for the same
reason (victim is a local mount point).
Filesystems could return EBUSY for other operations, so just map it
in server for all operations.
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
Chuck,
I ran into this error with a FUSE filesystem and returns -EBUSY on open,
but I noticed that vfs can also return EBUSY at least for rename().
Thanks,
Amir.
fs/nfsd/vfs.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
index 29cb7b812d713..a61f99c081894 100644
--- a/fs/nfsd/vfs.c
+++ b/fs/nfsd/vfs.c
@@ -100,6 +100,7 @@ nfserrno (int errno)
{ nfserr_perm, -ENOKEY },
{ nfserr_no_grace, -ENOGRACE},
{ nfserr_io, -EBADMSG },
+ { nfserr_file_open, -EBUSY},
};
int i;
@@ -2006,14 +2007,7 @@ nfsd_unlink(struct svc_rqst *rqstp, struct svc_fh *fhp, int type,
out_drop_write:
fh_drop_write(fhp);
out_nfserr:
- if (host_err == -EBUSY) {
- /* name is mounted-on. There is no perfect
- * error status.
- */
- err = nfserr_file_open;
- } else {
- err = nfserrno(host_err);
- }
+ err = nfserrno(host_err);
out:
return err;
out_unlock:
--
2.34.1
next reply other threads:[~2025-01-20 17:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-20 17:20 Amir Goldstein [this message]
2025-01-20 17:28 ` [PATCH] nfsd: map EBUSY for all operations Trond Myklebust
2025-01-20 18:21 ` Amir Goldstein
2025-01-20 18:45 ` Trond Myklebust
2025-01-20 19:14 ` Amir Goldstein
2025-01-20 19:29 ` Trond Myklebust
2025-01-20 19:44 ` Chuck Lever
2025-01-20 21:11 ` Amir Goldstein
2025-01-20 22:15 ` Trond Myklebust
2025-01-21 10:14 ` Amir Goldstein
2025-01-20 23:02 ` NeilBrown
2025-01-21 10:17 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250120172016.397916-1-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=chuck.lever@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox