From: Eric Biggers <ebiggers@kernel.org>
To: David Howells <dhowells@redhat.com>
Cc: Alex Markuze <amarkuze@redhat.com>,
fstests@vger.kernel.org, ceph-devel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: Error in generic/397 test script?
Date: Mon, 20 Jan 2025 09:25:42 -0800 [thread overview]
Message-ID: <20250120172542.GC1159@sol.localdomain> (raw)
In-Reply-To: <1207325.1737387826@warthog.procyon.org.uk>
On Mon, Jan 20, 2025 at 03:43:46PM +0000, David Howells wrote:
> David Howells <dhowells@redhat.com> wrote:
>
> > However, in this case (in which I'm running these against ceph), I don't think
> > that the find should return nothing, so it's not a bug in the test script per
> > se.
>
> Turned out that I hadn't enabled XTS and so the tests for xts(aes) failed and
> produced no files.
>
> David
AES-XTS support is mandatory for fscrypt, as is documented in fscrypt.rst. The
filesystems that support fscrypt select FS_ENCRYPTION_ALGS, which has "imply
CRYPTO_XTS" and "imply CRYPTO_AES". As explained in the comment just above it,
the reason that it's "imply" rather than "select" is so people can disable the
generic implementations of these algorithms if they know that an optimized
implementation will always be available.
It would be enlightening to understand what the issue was here. Did you
explicitly disable these options, overriding the imply, without providing a
replacement? Or was this another issue specific to unmerged kernel patches?
- Eric
next prev parent reply other threads:[~2025-01-20 17:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-20 12:32 Error in generic/397 test script? David Howells
2025-01-20 14:20 ` David Howells
2025-01-20 15:43 ` David Howells
2025-01-20 17:25 ` Eric Biggers [this message]
2025-01-20 17:41 ` David Howells
2025-01-20 17:46 ` Eric Biggers
2025-01-20 17:53 ` Eric Biggers
2025-01-20 17:19 ` Eric Biggers
2025-01-20 17:17 ` Eric Biggers
2025-01-20 17:26 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250120172542.GC1159@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=amarkuze@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=dhowells@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox