From: Al Viro <viro@zeniv.linux.org.uk>
To: Viacheslav Dubeyko <slava@dubeyko.com>
Cc: ceph-devel@vger.kernel.org, idryomov@gmail.com,
linux-fsdevel@vger.kernel.org, pdonnell@redhat.com,
amarkuze@redhat.com, Slava.Dubeyko@ibm.com
Subject: Re: [PATCH] ceph: is_root_ceph_dentry() cleanup
Date: Tue, 28 Jan 2025 03:07:28 +0000 [thread overview]
Message-ID: <20250128030728.GN1977892@ZenIV> (raw)
In-Reply-To: <20250128011023.55012-1-slava@dubeyko.com>
On Mon, Jan 27, 2025 at 05:10:23PM -0800, Viacheslav Dubeyko wrote:
> From: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>
>
> This patch introduces CEPH_HIDDEN_DIR_NAME. It
> declares name of the hidden directory .ceph in
> the include/linux/ceph/ceph_fs.h instead of hiding
> it in dir.c file. Also hardcoded length of the name
> is changed on strlen(CEPH_HIDDEN_DIR_NAME).
Hmm...
Speaking of that area
* how the hell could ceph_lookup() ever be called with dentry
that is *NOT* negative? VFS certainly won't do that; I'm not sure about
ceph_handle_notrace_create(), but it doesn't look like that's possible
without server being malicious (if it's possible at all).
* speaking of malicious servers, what happens if
it gets CEPH_MDS_OP_LOOKUP and it returns a normal reply to positive
lookup, but with cpu_to_le32(-ENOENT) shoved into head->result?
AFAICS, ceph_handle_snapdir() will be called with dentry
that is already made positive; results will not be pretty...
next prev parent reply other threads:[~2025-01-28 3:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-28 1:10 [PATCH] ceph: is_root_ceph_dentry() cleanup Viacheslav Dubeyko
2025-01-28 3:07 ` Al Viro [this message]
2025-01-28 23:27 ` Viacheslav Dubeyko
2025-01-29 1:12 ` Al Viro
2025-02-11 0:08 ` Viacheslav Dubeyko
2025-02-11 0:15 ` Al Viro
2025-02-11 18:01 ` Viacheslav Dubeyko
2025-02-11 19:01 ` Al Viro
2025-02-11 19:32 ` Viacheslav Dubeyko
2025-02-11 21:40 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250128030728.GN1977892@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=Slava.Dubeyko@ibm.com \
--cc=amarkuze@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=pdonnell@redhat.com \
--cc=slava@dubeyko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).