From: Al Viro <viro@zeniv.linux.org.uk>
To: Oliver Sang <oliver.sang@intel.com>
Cc: oe-lkp@lists.linux.dev, lkp@intel.com,
linux-kernel@vger.kernel.org,
Christian Brauner <brauner@kernel.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [linus:master] [do_pollfd()] 8935989798: will-it-scale.per_process_ops 11.7% regression
Date: Tue, 28 Jan 2025 19:10:42 +0000 [thread overview]
Message-ID: <20250128191042.GO1977892@ZenIV> (raw)
In-Reply-To: <Z5ilYwlw9+8/9N3U@xsang-OptiPlex-9020>
On Tue, Jan 28, 2025 at 05:37:39PM +0800, Oliver Sang wrote:
> > Just to make sure it's not a geniune change of logics somewhere,
> > could you compare d000e073ca2a, 893598979838 and d000e073ca2a with the
> > delta below? That delta provably is an equivalent transformation - all
> > exits from do_pollfd() go through the return in the end, so that just
> > shifts the last assignment in there into the caller.
>
> the 'd000e073ca2a with the delta below' has just very similar score as
> d000e073ca2a as below.
Not a change of logics, then... AFAICS, the only differences in code generation
here are different spills and conditional fput() not taken out of line.
I'm somewhat surprised by the amount of slowdowns, TBH... Is there any
chance to get per-insn profiles for those? How much time is spent in
each insn of do_poll()/do_pollfd()?
next prev parent reply other threads:[~2025-01-28 19:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-26 8:16 [linus:master] [do_pollfd()] 8935989798: will-it-scale.per_process_ops 11.7% regression kernel test robot
2025-01-27 19:26 ` Al Viro
2025-01-28 9:37 ` Oliver Sang
2025-01-28 19:10 ` Al Viro [this message]
2025-02-18 5:31 ` Oliver Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250128191042.GO1977892@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-lkp@lists.linux.dev \
--cc=oliver.sang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox