From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E43421AAA1F; Wed, 29 Jan 2025 15:44:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738165459; cv=none; b=reuVNCmBGSLJpPDkWoLhv06IKDHtHMtpx5ixoT71hy+R2+wckar+oIeE5R3L8AJJuQtyKXkjti1BGpSGpPY/7axwE3frLLh1ujPhsy4p6/EOOLyIFZ8MNvgdgAQGsnjWXyUSFFNM5Bc7bikcKgp/otc9vLMN/t+JXXidwknBR5M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738165459; c=relaxed/simple; bh=DTdOdu7VO+UHz3gmFsMZ5Nr7Syh5yplnddC/linvd9Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=I3pTcpIK5D5bVlHbnK8NjKUFkcNGLvabJaRfOeR4o8tVlfabmZlfcc8jd5gWHyRLSVzF56y4tbPvafn16fp+y0CDFCpbnAKuDRwlF2WL+hz4i2MYj1/tAcmH3VtysjcDPYCFgg0GlYjAXXuxIqE9VnTteTqpoaljfs/9bVHw2zo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 424F668D0D; Wed, 29 Jan 2025 16:44:14 +0100 (CET) Date: Wed, 29 Jan 2025 16:44:13 +0100 From: Christoph Hellwig To: Andreas Gruenbacher Cc: Christian Brauner , Christoph Hellwig , gfs2@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] lockref: remove count argument of lockref_init Message-ID: <20250129154413.GD7369@lst.de> References: <20250129143353.1892423-1-agruenba@redhat.com> <20250129143353.1892423-4-agruenba@redhat.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250129143353.1892423-4-agruenba@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Maybe the lockref_init kerneldoc now needs to say that it's initialized to a hold count of 1? Otherwise looks good: Reviewed-by: Christoph Hellwig