From: Brian Foster <bfoster@redhat.com>
To: linux-fsdevel@vger.kernel.org
Cc: linux-xfs@vger.kernel.org, Christoph Hellwig <hch@infradead.org>
Subject: [PATCH v4 04/10] iomap: lift error code check out of iomap_iter_advance()
Date: Tue, 4 Feb 2025 08:30:38 -0500 [thread overview]
Message-ID: <20250204133044.80551-5-bfoster@redhat.com> (raw)
In-Reply-To: <20250204133044.80551-1-bfoster@redhat.com>
The error code is only used to check whether iomap_iter() should
terminate due to an error returned in iter.processed. Lift the check
out of iomap_iter_advance() in preparation to make it more generic.
Signed-off-by: Brian Foster <bfoster@redhat.com>
---
fs/iomap/iter.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/fs/iomap/iter.c b/fs/iomap/iter.c
index a2ae99fe6431..fcc8d75dd22f 100644
--- a/fs/iomap/iter.c
+++ b/fs/iomap/iter.c
@@ -30,8 +30,6 @@ static inline int iomap_iter_advance(struct iomap_iter *iter, s64 count)
bool stale = iter->iomap.flags & IOMAP_F_STALE;
int ret = 1;
- if (count < 0)
- return count;
if (WARN_ON_ONCE(count > iomap_length(iter)))
return -EIO;
iter->pos += count;
@@ -86,6 +84,11 @@ int iomap_iter(struct iomap_iter *iter, const struct iomap_ops *ops)
return ret;
}
+ if (iter->processed < 0) {
+ iomap_iter_reset_iomap(iter);
+ return iter->processed;
+ }
+
/* advance and clear state from the previous iteration */
ret = iomap_iter_advance(iter, iter->processed);
iomap_iter_reset_iomap(iter);
--
2.48.1
next prev parent reply other threads:[~2025-02-04 13:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 13:30 [PATCH v4 00/10] iomap: incremental per-operation iter advance Brian Foster
2025-02-04 13:30 ` [PATCH v4 01/10] iomap: factor out iomap length helper Brian Foster
2025-02-04 13:30 ` [PATCH v4 02/10] iomap: split out iomap check and reset logic from iter advance Brian Foster
2025-02-04 19:30 ` Darrick J. Wong
2025-02-04 19:48 ` Brian Foster
2025-02-04 13:30 ` [PATCH v4 03/10] iomap: refactor iomap_iter() length check and tracepoint Brian Foster
2025-02-04 13:50 ` Christoph Hellwig
2025-02-04 13:30 ` Brian Foster [this message]
2025-02-04 13:51 ` [PATCH v4 04/10] iomap: lift error code check out of iomap_iter_advance() Christoph Hellwig
2025-02-04 19:23 ` Darrick J. Wong
2025-02-04 19:48 ` Brian Foster
2025-02-04 13:30 ` [PATCH v4 05/10] iomap: lift iter termination logic from iomap_iter_advance() Brian Foster
2025-02-04 13:51 ` Christoph Hellwig
2025-02-04 19:52 ` Darrick J. Wong
2025-02-04 20:15 ` Brian Foster
2025-02-04 13:30 ` [PATCH v4 06/10] iomap: export iomap_iter_advance() and return remaining length Brian Foster
2025-02-04 13:52 ` Christoph Hellwig
2025-02-04 13:30 ` [PATCH v4 07/10] iomap: support incremental iomap_iter advances Brian Foster
2025-02-04 13:30 ` [PATCH v4 08/10] iomap: advance the iter directly on buffered writes Brian Foster
2025-02-04 13:30 ` [PATCH v4 09/10] iomap: advance the iter directly on unshare range Brian Foster
2025-02-04 13:30 ` [PATCH v4 10/10] iomap: advance the iter directly on zero range Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250204133044.80551-5-bfoster@redhat.com \
--to=bfoster@redhat.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).