From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C0C62135B6 for ; Tue, 4 Feb 2025 14:39:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738679985; cv=none; b=eZOWQOEHBXEtBT/9/FFjk3bxw4tQ9EnyzYTTpwSWUFsuxtGR0UTAkS00JHuHJj1v/cR/Xmrnxy3XT1/b7A6ar+sp4XjTc4kEkb+eeAY2AYKG9830J5a9QJkrtGeR5+J1QplrVJZgJAlWBaKpNclqyKmZB558sdFNQW16De2GeNs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738679985; c=relaxed/simple; bh=NK6U2eAdcsCFFLkWKaca2nbec36RdO4wjEij8v3CPvE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JEnh3k9BnLZ1jrBvcVI/xlO9UxWPe9zg1yAoSg59GXxUyt5txptdTlNGUBZi5H8Y19888avBgB9FwJUEPklS3/wi9i1n8OcwqnI0MCA4z08I8nnnU/UDnY2cSbPIhmwNdGbpvVdWT+QSYl3KsdAGL9XX1NyDHV7vNkvCElaW4rk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=MAyTjb8/; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MAyTjb8/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738679982; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sQWJz8pfF5VlA3eUj44/2CtOhMxwtbJLSsIHRwy6GfU=; b=MAyTjb8/DZN+Kwezq1K2a8IMPKKjsrRdvstRTnOM7Sp8v+KnFqnOL0+HsNzEN8VPOUzGbi Ic+Nb6m2jNndLQPB0yNZMltkENoY8Fw/1IkiBtcxA+uUbddXiCUm5ULejG+zHLSPStxsVY Z2n8rQdqu4b4tJVt1vldjhdiEj2MK9E= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-1-iVU-Q94ANmmGe9zTuvdGkQ-1; Tue, 04 Feb 2025 09:39:39 -0500 X-MC-Unique: iVU-Q94ANmmGe9zTuvdGkQ-1 X-Mimecast-MFC-AGG-ID: iVU-Q94ANmmGe9zTuvdGkQ Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 46A971955DD0; Tue, 4 Feb 2025 14:39:37 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.44.32.214]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id A02CF1800358; Tue, 4 Feb 2025 14:39:32 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Tue, 4 Feb 2025 15:39:10 +0100 (CET) Date: Tue, 4 Feb 2025 15:39:05 +0100 From: Oleg Nesterov To: Mateusz Guzik Cc: Christian Brauner , Linus Torvalds , David Howells , "Gautham R. Shenoy" , K Prateek Nayak , Neeraj Upadhyay , Oliver Sang , Swapnil Sapkal , WangYuli , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pipe: don't update {a,c,m}time for anonymous pipes Message-ID: <20250204143904.GC6031@redhat.com> References: <20250204132153.GA20921@redhat.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 On 02/04, Mateusz Guzik wrote: > > > + if (ret > 0 && !is_pipe_inode(file_inode(filp))) { > > Total nit in case there is a v2: > > ret is typically > 0 and most of the time this is going to be an > anonymous pipe, so I would swap these conditions around. > > A not nit is that "is_pipe_inode" is imo misleading -- a named pipe > inode is also a pipe inode. How about "is_anon_pipe"? OK, I'll wait for other reviews and send v2 with the changes you suggest. Oleg.