Re: [PATCH v6 15/26] huge_memory: Add vmf_insert_folio_pud()

Dan Williams
2025-01-14T01:28:01Z

Alistair Popple wrote:
> Currently DAX folio/page reference counts are managed differently to
> normal pages. To allow these to be managed the same as normal pages
> introduce vmf_insert_folio_pud. This will map the entire PUD-sized folio
> and take references as it would for a normally mapped page.
>
> This is distinct from the current mechanism, vmf_insert_pfn_pud, which
> simply inserts a special devmap PUD entry into the page table without
> holding a reference to the page for the mapping.
>
> Signed-off-by: Alistair Popple <apopple@nvidia.com>

Looks correct for what it is:

Reviewed-by: Dan Williams <dan.j.williams@intel.com>