From: Mateusz Guzik <mjguzik@gmail.com>
To: brauner@kernel.org
Cc: viro@zeniv.linux.org.uk, jack@suse.cz,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Mateusz Guzik <mjguzik@gmail.com>
Subject: [PATCH v3 0/3] CONFIG_VFS_DEBUG at last
Date: Sat, 8 Feb 2025 17:26:08 +0100 [thread overview]
Message-ID: <20250208162611.628145-1-mjguzik@gmail.com> (raw)
This adds a super basic version just to get the mechanism going, along
with sample usage.
The macro set is incomplete (e.g., lack of locking macros) and
dump_inode routine fails to dump any state yet, to be implemented(tm).
I think despite the primitive state this is complete enough to start
sprinkling asserts as necessary.
v3:
- move dump_inode to fs/inode.c
- s/failed/encountered/
- pr_warn instead of pr_crit, matches dump_mapping
v2:
- correct may_open
- fixed up condition reporting:
before:
VFS_WARN_ON_INODE(__builtin_choose_expr((sizeof(int) ==
sizeof(*(8 ? ((void *)((long)(__builtin_strlen(link)) * 0l)) : (int
*)8))), __builtin_strlen(link), __fortify_strlen(link)) != linklen)
failed for inode ff32f7c350c8aec8
after:
VFS_WARN_ON_INODE(strlen(link) != linklen) failed for inode ff2b81ddca13f338
Mateusz Guzik (3):
vfs: add initial support for CONFIG_VFS_DEBUG
vfs: catch invalid modes in may_open()
vfs: use the new debug macros in inode_set_cached_link()
fs/inode.c | 12 +++++++++++
fs/namei.c | 2 ++
include/linux/fs.h | 16 +++-----------
include/linux/vfsdebug.h | 45 ++++++++++++++++++++++++++++++++++++++++
lib/Kconfig.debug | 9 ++++++++
5 files changed, 71 insertions(+), 13 deletions(-)
create mode 100644 include/linux/vfsdebug.h
--
2.43.0
next reply other threads:[~2025-02-08 16:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-08 16:26 Mateusz Guzik [this message]
2025-02-08 16:26 ` [PATCH v3 1/3] vfs: add initial support for CONFIG_VFS_DEBUG Mateusz Guzik
2025-02-08 16:26 ` [PATCH v3 2/3] vfs: catch invalid modes in may_open() Mateusz Guzik
2025-02-08 16:26 ` [PATCH v3 3/3] vfs: use the new debug macros in inode_set_cached_link() Mateusz Guzik
2025-02-09 17:25 ` kernel test robot
2025-02-10 8:21 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250208162611.628145-1-mjguzik@gmail.com \
--to=mjguzik@gmail.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox