From: Thorsten Blum <thorsten.blum@linux.dev>
To: Christian Brauner <brauner@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Jeff Layton <jlayton@kernel.org>,
Adrian Ratiu <adrian.ratiu@collabora.com>,
xu xin <xu.xin16@zte.com.cn>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Felix Moessbauer <felix.moessbauer@siemens.com>
Cc: Thorsten Blum <thorsten.blum@linux.dev>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: [PATCH] proc: Use str_yes_no() helper in proc_pid_ksm_stat()
Date: Wed, 12 Feb 2025 12:59:52 +0100 [thread overview]
Message-ID: <20250212115954.111652-2-thorsten.blum@linux.dev> (raw)
Remove hard-coded strings by using the str_yes_no() helper function.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
fs/proc/base.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/proc/base.c b/fs/proc/base.c
index cd89e956c322..f28acc5d5ec8 100644
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -60,6 +60,7 @@
#include <linux/file.h>
#include <linux/generic-radix-tree.h>
#include <linux/string.h>
+#include <linux/string_choices.h>
#include <linux/seq_file.h>
#include <linux/namei.h>
#include <linux/mnt_namespace.h>
@@ -3280,14 +3281,14 @@ static int proc_pid_ksm_stat(struct seq_file *m, struct pid_namespace *ns,
seq_printf(m, "ksm_merging_pages %lu\n", mm->ksm_merging_pages);
seq_printf(m, "ksm_process_profit %ld\n", ksm_process_profit(mm));
seq_printf(m, "ksm_merge_any: %s\n",
- test_bit(MMF_VM_MERGE_ANY, &mm->flags) ? "yes" : "no");
+ str_yes_no(test_bit(MMF_VM_MERGE_ANY, &mm->flags)));
ret = mmap_read_lock_killable(mm);
if (ret) {
mmput(mm);
return ret;
}
seq_printf(m, "ksm_mergeable: %s\n",
- ksm_process_mergeable(mm) ? "yes" : "no");
+ str_yes_no(ksm_process_mergeable(mm)));
mmap_read_unlock(mm);
mmput(mm);
}
--
2.48.1
next reply other threads:[~2025-02-12 12:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 11:59 Thorsten Blum [this message]
2025-02-12 12:04 ` [PATCH] proc: Use str_yes_no() helper in proc_pid_ksm_stat() Al Viro
2025-02-12 12:11 ` Thorsten Blum
2025-02-12 12:36 ` Al Viro
2025-02-12 16:04 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250212115954.111652-2-thorsten.blum@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=adrian.ratiu@collabora.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=felix.moessbauer@siemens.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=xu.xin16@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox