From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
To: Joseph Qi <joseph.qi@linux.alibaba.com>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
Mark Tinguely <mark.tinguely@oracle.com>,
ocfs2-devel@lists.linux.dev, linux-fsdevel@vger.kernel.org
Subject: [PATCH 1/2] ocfs2: Use b_folio in ocfs2_symlink_get_block()
Date: Thu, 13 Feb 2025 18:37:27 +0000 [thread overview]
Message-ID: <20250213183730.2141556-1-willy@infradead.org> (raw)
We are preparing to remove bh->b_page. While modifying this function,
switch from kmap_atomic to kmap_local, remove the test for kmap_local
failing (it cannot), and reflow the conditional to match kernel coding
style.
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
fs/ocfs2/aops.c | 17 ++++++-----------
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c
index 5bbeb6fbb1ac..4790e2ba1671 100644
--- a/fs/ocfs2/aops.c
+++ b/fs/ocfs2/aops.c
@@ -91,17 +91,12 @@ static int ocfs2_symlink_get_block(struct inode *inode, sector_t iblock,
* could've happened. Since we've got a reference on
* the bh, even if it commits while we're doing the
* copy, the data is still good. */
- if (buffer_jbd(buffer_cache_bh)
- && ocfs2_inode_is_new(inode)) {
- kaddr = kmap_atomic(bh_result->b_page);
- if (!kaddr) {
- mlog(ML_ERROR, "couldn't kmap!\n");
- goto bail;
- }
- memcpy(kaddr + (bh_result->b_size * iblock),
- buffer_cache_bh->b_data,
- bh_result->b_size);
- kunmap_atomic(kaddr);
+ if (buffer_jbd(buffer_cache_bh) && ocfs2_inode_is_new(inode)) {
+ kaddr = kmap_local_folio(bh_result->b_folio,
+ bh_result->b_size * iblock);
+ memcpy(kaddr, buffer_cache_bh->b_data,
+ bh_result->b_size);
+ kunmap_local(kaddr);
set_buffer_uptodate(bh_result);
}
brelse(buffer_cache_bh);
--
2.47.2
next reply other threads:[~2025-02-13 18:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 18:37 Matthew Wilcox (Oracle) [this message]
2025-02-13 18:37 ` [PATCH 2/2] ocfs2: Remove reference to bh->b_page Matthew Wilcox (Oracle)
2025-02-13 18:58 ` [PATCH 1/2] ocfs2: Use b_folio in ocfs2_symlink_get_block() Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250213183730.2141556-1-willy@infradead.org \
--to=willy@infradead.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mark.tinguely@oracle.com \
--cc=ocfs2-devel@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).