From: Kees Cook <kees@kernel.org>
To: Sumya Hoque <sumyahoque2012@gmail.com>
Cc: skhan@linuxfoundation.org, linux-kernel@vger.kernel.org,
shuah@kernel.org, linux-fsdevel@vger.kernel.org,
linux-kselftest@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] selftests:sysctl:Fix minor grammers in sysctl test
Date: Wed, 19 Feb 2025 09:13:04 -0800 [thread overview]
Message-ID: <202502190912.CA03B56796@keescook> (raw)
In-Reply-To: <20250219030451.39782-1-sumyahoque2012@gmail.com>
On Wed, Feb 19, 2025 at 03:04:51AM +0000, Sumya Hoque wrote:
> Hello everyone,
> Some minor grammer issues that I have fixed:
> 1. echo "If an error every occurs --> echo "If an error occurs, every execution
> 2. Example uses --> Example Usage
>
> Signed-off-by: Sumya Hoque <sumyahoque2012@gmail.com>
> ---
> tools/testing/selftests/sysctl/sysctl.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/sysctl/sysctl.sh b/tools/testing/selftests/sysctl/sysctl.sh
> index 84472b436c07..a4d76147ed8a 100755
> --- a/tools/testing/selftests/sysctl/sysctl.sh
> +++ b/tools/testing/selftests/sysctl/sysctl.sh
> @@ -891,11 +891,11 @@ usage()
> echo " -l List all test ID list"
> echo " -h|--help Help"
> echo
> - echo "If an error every occurs execution will immediately terminate."
> + echo "If an error occurs, every execution will immediately terminate."
I think the typo here is just "every" -> "ever"
> echo "If you are adding a new test try using -w <test-ID> first to"
> echo "make sure the test passes a series of tests."
> echo
> - echo Example uses:
> + echo Example usage:
> echo
> echo "$TEST_NAME.sh -- executes all tests"
> echo "$TEST_NAME.sh -t 0002 -- Executes test ID 0002 number of times is recomended"
> --
> 2.34.1
>
--
Kees Cook
next prev parent reply other threads:[~2025-02-19 17:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 3:04 [PATCH] selftests:sysctl:Fix minor grammers in sysctl test Sumya Hoque
2025-02-19 17:13 ` Kees Cook [this message]
2025-02-19 19:33 ` [PATCH v2] selftests:sysctl:Fix minor typos " Sumya Hoque
2025-02-20 5:35 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202502190912.CA03B56796@keescook \
--to=kees@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=sumyahoque2012@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).