From: Al Viro <viro@zeniv.linux.org.uk>
To: Namjae Jeon <namjae.jeon@samsung.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: [RFC] weird stuff in exfat_lookup()
Date: Thu, 27 Feb 2025 22:48:26 +0000 [thread overview]
Message-ID: <20250227224826.GG2023217@ZenIV> (raw)
There's a really odd comment in that thing:
/*
* Unhashed alias is able to exist because of revalidate()
* called by lookup_fast. You can easily make this status
* by calling create and lookup concurrently
* In such case, we reuse an alias instead of new dentry
*/
and AFAICS it had been there since the original merge. What I don't
understand is how the hell could revalidate result in that -
exfat_d_revalidate() always returns 1 on any positive dentry and alias is
obviously positive (it has the same inode as the one we are about to use).
It mentions a way to reproduce that, but I don't understand what does
that refer to; could you give details?
next reply other threads:[~2025-02-27 22:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 22:48 Al Viro [this message]
2025-02-28 5:44 ` [RFC] weird stuff in exfat_lookup() Namjae Jeon
2025-02-28 16:03 ` Sungjong Seo
2025-03-13 12:39 ` Sungjong Seo
2026-04-03 19:54 ` Al Viro
2026-04-03 20:02 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250227224826.GG2023217@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox