From: Christian Brauner <brauner@kernel.org>
To: Pan Deng <pan.deng@intel.com>
Cc: Christian Brauner <brauner@kernel.org>,
tianyou.li@intel.com, tim.c.chen@linux.intel.com,
lipeng.zhu@intel.com, viro@zeniv.linux.org.uk, jack@suse.cz,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fs: place f_ref to 3rd cache line in struct file to resolve false sharing
Date: Fri, 28 Feb 2025 11:15:03 +0100 [thread overview]
Message-ID: <20250228-bestzeit-sondieren-0fc0d185fa4d@brauner> (raw)
In-Reply-To: <20250228020059.3023375-1-pan.deng@intel.com>
On Fri, 28 Feb 2025 10:00:59 +0800, Pan Deng wrote:
> When running syscall pread in a high core count system, f_ref contends
> with the reading of f_mode, f_op, f_mapping, f_inode, f_flags in the
> same cache line.
>
> This change places f_ref to the 3rd cache line where fields are not
> updated as frequently as the 1st cache line, and the contention is
> grealy reduced according to tests. In addition, the size of file
> object is kept in 3 cache lines.
>
> [...]
Applied to the vfs-6.15.misc branch of the vfs/vfs.git tree.
Patches in the vfs-6.15.misc branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-6.15.misc
[1/1] fs: place f_ref to 3rd cache line in struct file to resolve false sharing
https://git.kernel.org/vfs/vfs/c/6a9ebf00c3be
next prev parent reply other threads:[~2025-02-28 10:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 2:00 [PATCH] fs: place f_ref to 3rd cache line in struct file to resolve false sharing Pan Deng
2025-02-28 10:15 ` Christian Brauner [this message]
2025-02-28 19:51 ` Jan Kara
2025-03-01 10:07 ` Christian Brauner
2025-03-04 10:36 ` Jan Kara
2025-03-04 10:50 ` Deng, Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250228-bestzeit-sondieren-0fc0d185fa4d@brauner \
--to=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=lipeng.zhu@intel.com \
--cc=pan.deng@intel.com \
--cc=tianyou.li@intel.com \
--cc=tim.c.chen@linux.intel.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox