linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-fsdevel@vger.kernel.org
Subject: [PATCH 1/4] f2fs: Remove check for ->writepage
Date: Fri,  7 Mar 2025 18:21:47 +0000	[thread overview]
Message-ID: <20250307182151.3397003-2-willy@infradead.org> (raw)
In-Reply-To: <20250307182151.3397003-1-willy@infradead.org>

We're almost able to remove a_ops->writepage.  This check is unnecessary
as we'll never call into __f2fs_write_data_pages() for character
devices.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
 fs/f2fs/data.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index c82d949709f4..a80d5ef9acbb 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -3280,10 +3280,6 @@ static int __f2fs_write_data_pages(struct address_space *mapping,
 	int ret;
 	bool locked = false;
 
-	/* deal with chardevs and other special file */
-	if (!mapping->a_ops->writepage)
-		return 0;
-
 	/* skip writing if there is no dirty page in this inode */
 	if (!get_dirty_pages(inode) && wbc->sync_mode == WB_SYNC_NONE)
 		return 0;
-- 
2.47.2


  reply	other threads:[~2025-03-07 18:21 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-07 18:21 [PATCH 0/4] f2fs: Remove uses of writepage Matthew Wilcox (Oracle)
2025-03-07 18:21 ` Matthew Wilcox (Oracle) [this message]
2025-03-11 11:48   ` [PATCH 1/4] f2fs: Remove check for ->writepage Chao Yu
2025-03-07 18:21 ` [PATCH 2/4] f2fs: Remove f2fs_write_data_page() Matthew Wilcox (Oracle)
2025-03-11 11:48   ` Chao Yu
2025-03-07 18:21 ` [PATCH 3/4] f2fs: Remove f2fs_write_meta_page() Matthew Wilcox (Oracle)
2025-03-11 11:49   ` Chao Yu
2025-03-07 18:21 ` [PATCH 4/4] f2fs: Remove f2fs_write_node_page() Matthew Wilcox (Oracle)
2025-03-11 11:49   ` Chao Yu
2025-03-07 20:39 ` [PATCH 0/4] f2fs: Remove uses of writepage Jaegeuk Kim
2025-03-07 20:48   ` Matthew Wilcox
2025-03-07 22:13     ` Jaegeuk Kim
2025-03-11 19:50 ` [f2fs-dev] " patchwork-bot+f2fs
2025-03-12  0:18   ` Matthew Wilcox
2025-03-12  1:22     ` Jaegeuk Kim
2025-03-14 15:57       ` Matthew Wilcox
2025-03-14 21:38         ` Jaegeuk Kim
2025-03-26  3:37           ` Matthew Wilcox
2025-03-27 22:27             ` Jaegeuk Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250307182151.3397003-2-willy@infradead.org \
    --to=willy@infradead.org \
    --cc=chao@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).