linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Jan Kara <jack@suse.cz>
Cc: Josef Bacik <josef@toxicpanda.com>,
	Christian Brauner <brauner@kernel.org>,
	linux-fsdevel@vger.kernel.org
Subject: [PATCH v3 0/6] Fix for potential deadlock in pre-content event
Date: Wed, 12 Mar 2025 08:38:46 +0100	[thread overview]
Message-ID: <20250312073852.2123409-1-amir73il@gmail.com> (raw)

Jan,

This is the mmap solution proposed by Josef to solve the potential
deadlock with faulting in user pages [1].

I've added test coverage to mmap() pre-content events and verified
no pre-content events on page fault [2].

After some push back on [v2] for disabling page fault pre-content hooks
while leaving their code in the kernel, this series revert the page
fault pre-content hooks.

This leaves DAX files access without pre-content hooks, but that was
never a goal for this feature, so I think that is fine.

Thanks,
Amir.

Changes since v2:
- Revert page fault pre-content hooks
- Remove mmap hook from remap_file_pages() (Lorenzo)
- Create fsnotify_mmap_perm() wrapper (Lorenzo)

[1] https://lore.kernel.org/linux-fsdevel/20250307154614.GA59451@perftesting/
[2] https://github.com/amir73il/ltp/commits/fan_hsm/
[v2] https://lore.kernel.org/linux-fsdevel/20250311114153.1763176-1-amir73il@gmail.com/
[v1] https://lore.kernel.org/linux-fsdevel/20250309115207.908112-1-amir73il@gmail.com/

Amir Goldstein (6):
  fsnotify: add pre-content hooks on mmap()
  Revert "ext4: add pre-content fsnotify hook for DAX faults"
  Revert "xfs: add pre-content fsnotify hook for DAX faults"
  Revert "fsnotify: generate pre-content permission event on page fault"
  Revert "mm: don't allow huge faults for files with pre content
    watches"
  Revert "fanotify: disable readahead if we have pre-content watches"

 fs/ext4/file.c           |  3 --
 fs/xfs/xfs_file.c        | 13 ------
 include/linux/fsnotify.h | 21 ++++++++++
 include/linux/mm.h       |  1 -
 mm/filemap.c             | 86 ----------------------------------------
 mm/memory.c              | 19 ---------
 mm/nommu.c               |  7 ----
 mm/readahead.c           | 14 -------
 mm/util.c                |  3 ++
 9 files changed, 24 insertions(+), 143 deletions(-)

-- 
2.34.1


             reply	other threads:[~2025-03-12  7:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-12  7:38 Amir Goldstein [this message]
2025-03-12  7:38 ` [PATCH v3 1/6] fsnotify: add pre-content hooks on mmap() Amir Goldstein
2025-03-12  7:38 ` [PATCH v3 2/6] Revert "ext4: add pre-content fsnotify hook for DAX faults" Amir Goldstein
2025-03-12  7:38 ` [PATCH v3 3/6] Revert "xfs: " Amir Goldstein
2025-03-12  7:38 ` [PATCH v3 4/6] Revert "fsnotify: generate pre-content permission event on page fault" Amir Goldstein
2025-03-12  7:38 ` [PATCH v3 5/6] Revert "mm: don't allow huge faults for files with pre content watches" Amir Goldstein
2025-03-12  7:38 ` [PATCH v3 6/6] Revert "fanotify: disable readahead if we have pre-content watches" Amir Goldstein
2025-03-12 16:56 ` [PATCH v3 0/6] Fix for potential deadlock in pre-content event Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250312073852.2123409-1-amir73il@gmail.com \
    --to=amir73il@gmail.com \
    --cc=brauner@kernel.org \
    --cc=jack@suse.cz \
    --cc=josef@toxicpanda.com \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).