From: Christoph Hellwig <hch@lst.de>
To: Mateusz Guzik <mjguzik@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
Gao Xiang <xiang@kernel.org>, Chao Yu <chao@kernel.org>,
Andreas Gruenbacher <agruenba@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-erofs@lists.ozlabs.org, gfs2@lists.linux.dev
Subject: Re: [PATCH 3/8] lockref: use bool for false/true returns
Date: Wed, 19 Mar 2025 07:29:23 +0100 [thread overview]
Message-ID: <20250319062923.GA23686@lst.de> (raw)
In-Reply-To: <CAGudoHEW=MmNLQSnvZ3MJy0KAnGuKKNGevOccd2LdiuUWcb0Yg@mail.gmail.com>
On Tue, Mar 18, 2025 at 04:51:27PM +0100, Mateusz Guzik wrote:
> fwiw I confirmed clang does *not* have the problem, I don't know about gcc 14.
>
> Maybe I'll get around to testing it, but first I'm gonna need to carve
> out the custom asm into a standalone testcase.
>
> Regardless, 13 suffering the problem is imo a good enough reason to
> whack the change.
Reverting a change because a specific compiler generates sligtly worse
code without even showing it has any real life impact feels like I'm
missing something important.
next prev parent reply other threads:[~2025-03-19 6:29 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 9:46 lockref cleanups Christoph Hellwig
2025-01-15 9:46 ` [PATCH 1/8] lockref: remove lockref_put_not_zero Christoph Hellwig
2025-01-15 9:46 ` [PATCH 2/8] lockref: improve the lockref_get_not_zero description Christoph Hellwig
2025-01-15 13:28 ` Andreas Gruenbacher
2025-01-15 9:46 ` [PATCH 3/8] lockref: use bool for false/true returns Christoph Hellwig
2025-03-18 15:25 ` Mateusz Guzik
2025-03-18 15:51 ` Mateusz Guzik
2025-03-19 6:29 ` Christoph Hellwig [this message]
2025-03-19 12:04 ` Mateusz Guzik
2025-03-20 5:34 ` Christoph Hellwig
2025-01-15 9:46 ` [PATCH 4/8] lockref: drop superfluous externs Christoph Hellwig
2025-01-15 9:46 ` [PATCH 5/8] lockref: add a lockref_init helper Christoph Hellwig
2025-01-15 9:46 ` [PATCH 6/8] dcache: use lockref_init for d_lockref Christoph Hellwig
2025-01-15 20:13 ` Dave Chinner
2025-01-15 20:30 ` Al Viro
2025-01-16 5:03 ` Dave Chinner
2025-01-15 9:46 ` [PATCH 7/8] erofs: use lockref_init for pcl->lockref Christoph Hellwig
2025-01-15 9:49 ` Gao Xiang
2025-01-15 9:46 ` [PATCH 8/8] gfs2: use lockref_init for qd_lockref Christoph Hellwig
2025-01-15 13:35 ` Andreas Gruenbacher
2025-01-16 4:32 ` Christoph Hellwig
2025-01-17 16:03 ` Andreas Gruenbacher
2025-01-20 15:25 ` Christian Brauner
2025-01-20 15:44 ` Andreas Gruenbacher
2025-01-22 12:59 ` Christian Brauner
2025-01-15 10:50 ` lockref cleanups Christian Brauner
2025-01-22 20:40 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250319062923.GA23686@lst.de \
--to=hch@lst.de \
--cc=agruenba@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=chao@kernel.org \
--cc=gfs2@lists.linux.dev \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjguzik@gmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox