From: Oleg Nesterov <oleg@redhat.com>
To: Christian Brauner <brauner@kernel.org>
Cc: linux-fsdevel@vger.kernel.org, Jeff Layton <jlayton@kernel.org>,
Lennart Poettering <lennart@poettering.net>,
Daan De Meyer <daan.j.demeyer@gmail.com>,
Mike Yuan <me@yhndnzj.com>
Subject: Re: [PATCH v4 1/4] pidfs: improve multi-threaded exec and premature thread-group leader exit polling
Date: Thu, 20 Mar 2025 15:28:17 +0100 [thread overview]
Message-ID: <20250320142817.GE11256@redhat.com> (raw)
In-Reply-To: <20250320-work-pidfs-thread_group-v4-1-da678ce805bf@kernel.org>
On 03/20, Christian Brauner wrote:
>
> Co-Developed-by: Oleg Nesterov <oleg@redhat.com>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
> Signed-off-by: Christian Brauner <brauner@kernel.org>
> ---
> fs/pidfs.c | 9 +++++----
> kernel/exit.c | 6 +++---
> kernel/signal.c | 3 +--
> 3 files changed, 9 insertions(+), 9 deletions(-)
Thanks, LGTM.
Todo:
- As we already discussed, do_notify_pidfd() can be called
twice from exit_notify() paths, we can avoid this.
But this connects to another minor issue:
- With this change, debuggers can no longer use PIDFD_THREAD.
I guess we don't really care, I don't think PIDFD_THREAD was
ever used for this purpose. but perhaps we can change this
or at least document somewhere...
I'll try to do this but not today and (most probably) not tomorrow.
Oleg.
next prev parent reply other threads:[~2025-03-20 14:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-20 13:24 [PATCH v4 0/4] pidfs: handle multi-threaded exec and premature thread-group leader exit Christian Brauner
2025-03-20 13:24 ` [PATCH v4 1/4] pidfs: improve multi-threaded exec and premature thread-group leader exit polling Christian Brauner
2025-03-20 14:28 ` Oleg Nesterov [this message]
2025-03-20 15:26 ` Christian Brauner
2025-03-20 13:24 ` [PATCH v4 2/4] selftests/pidfd: first test for multi-threaded exec polling Christian Brauner
2025-03-20 13:24 ` [PATCH v4 3/4] selftests/pidfd: second " Christian Brauner
2025-03-20 13:24 ` [PATCH v4 4/4] selftests/pidfd: third " Christian Brauner
2025-03-23 17:19 ` [PATCH] pidfs: cleanup the usage of do_notify_pidfd() Oleg Nesterov
2025-03-23 17:45 ` selftests/pidfd: (Was: [PATCH] pidfs: cleanup the usage of do_notify_pidfd()) Oleg Nesterov
2025-03-23 20:36 ` Christian Brauner
2025-03-23 21:17 ` Oleg Nesterov
2025-03-23 20:40 ` [PATCH] pidfs: cleanup the usage of do_notify_pidfd() Christian Brauner
2025-03-23 20:42 ` Christian Brauner
2025-03-24 17:19 ` [PATCH] exit: fix the usage of delay_group_leader->exit_code in do_notify_parent() and pidfs_exit() Oleg Nesterov
2025-03-25 14:57 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250320142817.GE11256@redhat.com \
--to=oleg@redhat.com \
--cc=brauner@kernel.org \
--cc=daan.j.demeyer@gmail.com \
--cc=jlayton@kernel.org \
--cc=lennart@poettering.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=me@yhndnzj.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).