From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.g.garry@oracle.com>
Cc: "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Christoph Hellwig <hch@lst.de>,
brauner@kernel.org, djwong@kernel.org, dchinner@redhat.com,
linux-kernel@vger.kernel.org, ojaswin@linux.ibm.com,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH] iomap: Fix conflicting values of iomap flags
Date: Fri, 28 Mar 2025 11:48:46 +0100 [thread overview]
Message-ID: <20250328104846.GB19460@lst.de> (raw)
In-Reply-To: <8f1fc565-9bbb-4bbb-ab53-3c47808ef257@oracle.com>
On Thu, Mar 27, 2025 at 10:04:14PM +0000, John Garry wrote:
> Just my opinion - and others will prob disagree - but I think that the
> reason this was missed (my fault, though) was because we have separate
> grouping of flags within the same struct member. Maybe having separate
> flags altogether would help avoid this.
Yes. But going down to less than 16 bit fields also has downsides, as
does growing the struture.
next prev parent reply other threads:[~2025-03-28 10:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-27 17:01 [PATCH] iomap: Fix conflicting values of iomap flags Ritesh Harjani (IBM)
2025-03-27 22:04 ` John Garry
2025-03-28 10:48 ` Christoph Hellwig [this message]
2025-03-28 9:45 ` Christian Brauner
2025-03-28 10:47 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250328104846.GB19460@lst.de \
--to=hch@lst.de \
--cc=brauner@kernel.org \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=john.g.garry@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).