From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A392120E024; Mon, 7 Apr 2025 16:43:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744044202; cv=none; b=M/QsMgqZYhSO6nEYedh8YRAghPQip/OOhanB+upwEsttKHqaVhxOvm4Aq5r23d5RPwn1Xus8wZtTfyVIhp8GF7GOOXe/2cD2N9iDghXzWVcejQciMgzTYFEZ3FCdmbxNr2B438G8SxxdGqG6q0UEStpcgnBwzazb/Szk2bEs54I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744044202; c=relaxed/simple; bh=j0/uZG8pR8l8gEcjOhin3TS18avmWQvepa/nVBrdipI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jfX1ZW+YjxBljFbJ3b6PCRMnBxR8jsfTnPMn1JtMVKYtEeDEPA1R6kv01JOf4BE168uuFNcQKhnhyXEwB4KZgAfBJLkQlaVw1osj+hi/YrVQ7yU5nQANSbPLnjtTHK7deqIU+RXnZHyseTESgYyFMVnLkIL2cp9lNj4Jr0vHtN0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hygnjSkh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hygnjSkh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 743AFC4CEDD; Mon, 7 Apr 2025 16:43:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744044202; bh=j0/uZG8pR8l8gEcjOhin3TS18avmWQvepa/nVBrdipI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hygnjSkhX1mwIwLYAUkDmG+87Kmz0zcdmJdcqzXtLFV4ZBxnvZ1Uo4zht0vJjf269 kyKu3VeWv58qx+NFrX5vZpJFfylmk3/kfFuBz4pT1uM+/+7urkE39lplcd79eUvF7h uZj2jscF5dkj1jj3e6LUnqmH1m4i6fUKTdqKKM01+MKbRAWmFEcI8qUrutMTLNuDXi 9Q/8LNf0o3Dna0iAed/2WsfsuLqNh/hA4RzRMS5WrO8KPjCw51MiaTF5oNfsw3q8Rr R8OngS7ywZjV1ibFo+lHevZXUOR00sHvQ9sBmZGdC3WmLFWXr73R3S0mlh6942H5RT mRyZ/ElnEc3xg== Date: Mon, 7 Apr 2025 09:43:21 -0700 From: "Darrick J. Wong" To: Christoph Hellwig Cc: John Garry , "Ritesh Harjani (IBM)" , linux-xfs@vger.kernel.org, ojaswin@linux.ibm.com, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 1/2] Documentation: iomap: Add missing flags description Message-ID: <20250407164321.GE6266@frogsfrogsfrogs> References: <3170ab367b5b350c60564886a72719ccf573d01c.1743691371.git.ritesh.list@gmail.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Apr 07, 2025 at 01:50:00AM -0700, Christoph Hellwig wrote: > On Fri, Apr 04, 2025 at 10:36:32AM +0100, John Garry wrote: > > > @@ -243,6 +243,11 @@ The fields are as follows: > > > regular file data. > > > This is only useful for FIEMAP. > > > + * **IOMAP_F_BOUNDARY**: This indicates that I/O and I/O completions > > > + for this iomap must never be merged with the mapping before it. > > > > This is just effectively the same comment as in the code - what's the use in > > this? > > Darrick asked for this file to have full comments. I'm more on your > side here as a lot of this seem redundant. Yes, some of it duplicates iomap.h's more terse comments. I'm willing to be flexible about some of this, so long as the documentation helps the /next/ person to understand iomap and how to use it. > > > + Currently XFS uses this to prevent merging of ioends across RTG > > > + (realtime group) boundaries. > > > + > > > * **IOMAP_F_PRIVATE**: Starting with this value, the upper bits can > > > be set by the filesystem for its own purposes. > > > > Is this comment now out of date according to your change in 923936efeb74? > > Also we probably should not detail file system behavior here, but a > high level description of what it is useful. Agreed (now). --D