From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BE971AF4C1 for ; Sun, 13 Apr 2025 12:41:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=18.9.28.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744548076; cv=none; b=J0lzX4joYs7nJCkvtK1gH44a4THlfcm7vfSj4nsC2rO2bmzs4PRwobpsCgwJ6P2dwOw9G03+55xrt1Qd7mf7Qmc3rW4HLrLaAJA8HhgFAPnLXYgOaOkJ7xYQ+2BwX3o+ECgWXyLKPcEzqehinwPF4/9NZYyUjuABcogfn3Gn41A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744548076; c=relaxed/simple; bh=Rq01d9ejvzex4376qmBcvzLJCfJ+SQ4pFJwanQ75ps0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=V930aNJl2zxCW09LXFu/noN6pDwPh/G3tJF6bPr01sdZRq10/JMPL5WGnHtqlGnvVSWaFK4slkcz+l0IyPfv1n4c6jYIDh5t1HNtwLUcujrD5CPdYvAwHdSx+BFZt0SXwbXFR8wxJ9QzAGRCvss+zcO9gVsPIRgfKbWqmomxPhI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu; spf=pass smtp.mailfrom=mit.edu; arc=none smtp.client-ip=18.9.28.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mit.edu Received: from trampoline.thunk.org (pool-173-48-82-137.bstnma.fios.verizon.net [173.48.82.137]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 53DCetGL009051 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 13 Apr 2025 08:40:55 -0400 Received: by trampoline.thunk.org (Postfix, from userid 15806) id E3B112E00E9; Sun, 13 Apr 2025 08:40:54 -0400 (EDT) Date: Sun, 13 Apr 2025 08:40:54 -0400 From: "Theodore Ts'o" To: Mateusz Guzik Cc: Linus Torvalds , Christian Brauner , Al Viro , linux-fsdevel , Jan Kara , Ext4 Developers List Subject: Re: generic_permission() optimization Message-ID: <20250413124054.GA1116327@mit.edu> References: <20250412215257.GF13132@mit.edu> <20250412235535.GH13132@mit.edu> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sun, Apr 13, 2025 at 11:41:47AM +0200, Mateusz Guzik wrote: > This is the rootfs of the thing, so I tried it out with merely > printing it. I got 70 entries at boot time. I don't think figuring out > what this is specifically is warranted (it is on debian though). Well, can you run: debugfs -R "stat " /dev/ROOT_DEV on say, two or three of the inodes (replace INO with a number, and ROOT_DEV with the root file system device) and send me the result? That would be really helpful in understanding what might be going on. > So... I think this is good enough to commit? I had no part in writing > the patch and I'm not an ext4 person, so I'm not submitting it myself. > > Ted, you seem fine with the patch, so perhaps you could do the needful(tm)? Sure, I'll put together a more formal patch and do full QA run and checking of the code paths, as a supposed a fairly superficial review and hack. - Ted