From: Al Viro <viro@zeniv.linux.org.uk>
To: Marco Elver <elver@google.com>
Cc: Christian Brauner <brauner@kernel.org>,
syzbot <syzbot+81fdaf0f522d5c5e41fb@syzkaller.appspotmail.com>,
jack@suse.cz, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [fs?] KCSAN: data-race in choose_mountpoint_rcu / umount_tree
Date: Tue, 22 Apr 2025 18:12:37 +0100 [thread overview]
Message-ID: <20250422171237.GA2023217@ZenIV> (raw)
In-Reply-To: <CANpmjNPbVDaw8hzYRRe2_uZ45Dkc-rwqg9oUhoiMo2zg6D0XKw@mail.gmail.com>
On Tue, Apr 22, 2025 at 04:42:52PM +0200, Marco Elver wrote:
> Seqlocks are generally supported, but have caused headaches in the
> past, esp. if the reader-side seqlock critical section does not follow
> the typical do-seqbegin-while-retry pattern, or the critical section
> is too large. If I read this right, the
>
> struct dentry *mountpoint = m->mnt_mountpoint;
>
> is before the seqlock-reader beginning with "*seqp =
> read_seqcount_begin(&mountpoint->d_seq);" ?
Different seqlock - mount_lock protects mount tree and it's been sampled
all way back in the beginning of RCU pathwalk...
prev parent reply other threads:[~2025-04-22 17:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 12:11 [syzbot] [fs?] KCSAN: data-race in choose_mountpoint_rcu / umount_tree syzbot
2025-04-22 13:43 ` Christian Brauner
2025-04-22 14:42 ` Marco Elver
2025-04-22 15:43 ` Christian Brauner
2025-04-22 17:12 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250422171237.GA2023217@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=brauner@kernel.org \
--cc=elver@google.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+81fdaf0f522d5c5e41fb@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox