From: Christoph Hellwig <hch@lst.de>
To: Christian Brauner <brauner@kernel.org>
Cc: Heiko Carstens <hca@linux.ibm.com>,
Christoph Hellwig <hch@lst.de>,
gregkh@linuxfoundation.org, rafael@kernel.org, dakr@kernel.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
Xiao Ni <xni@redhat.com>, Kees Cook <kees@kernel.org>
Subject: Re: [PATCH] devtmpfs: don't use vfs_getattr_nosec to query i_mode
Date: Fri, 25 Apr 2025 15:32:59 +0200 [thread overview]
Message-ID: <20250425133259.GA6626@lst.de> (raw)
In-Reply-To: <20250425-stehlen-koexistieren-c0f650dcccec@brauner>
On Fri, Apr 25, 2025 at 12:12:36PM +0200, Christian Brauner wrote:
> > That is: if dev_mynode(dev, inode) is not true some random value will be returned.
>
> Don't bother resending, Christoph.
> I've already fixed this with int err = 0 in the tree.
Thanks! Let me use this as a platform to rant about our option
defaults and/or gcc error handling. It seems like ever since we started
zeroing on-stack variables by default gcc stopped warnings about using
uninitialized on-stack variables, leading to tons of these case where
we don't catch uninitialized variables. Now in this and in many cases
the code works fine because it assumed zero initialization, but there are
also cases where it didn't, leading to new bugs.
Can we fix this somehow?
next prev parent reply other threads:[~2025-04-25 13:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 4:59 [PATCH] devtmpfs: don't use vfs_getattr_nosec to query i_mode Christoph Hellwig
2025-04-23 5:54 ` Christian Brauner
2025-04-23 6:42 ` Greg KH
2025-04-24 8:40 ` Christian Brauner
2025-04-23 6:45 ` Heiko Carstens
2025-04-24 5:07 ` Jain, Ayush
2025-04-24 8:41 ` Christian Brauner
2025-04-25 10:03 ` Heiko Carstens
2025-04-25 10:12 ` Christian Brauner
2025-04-25 13:32 ` Christoph Hellwig [this message]
2025-04-25 15:40 ` Kees Cook
2025-04-25 17:17 ` Nathan Chancellor
2025-04-28 13:15 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250425133259.GA6626@lst.de \
--to=hch@lst.de \
--cc=brauner@kernel.org \
--cc=dakr@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hca@linux.ibm.com \
--cc=kees@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
--cc=xni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).