From: Christoph Hellwig <hch@lst.de>
To: Kees Cook <kees@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
Christian Brauner <brauner@kernel.org>,
Heiko Carstens <hca@linux.ibm.com>,
gregkh@linuxfoundation.org, rafael@kernel.org, dakr@kernel.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
Xiao Ni <xni@redhat.com>
Subject: Re: [PATCH] devtmpfs: don't use vfs_getattr_nosec to query i_mode
Date: Mon, 28 Apr 2025 15:15:30 +0200 [thread overview]
Message-ID: <20250428131530.GA30382@lst.de> (raw)
In-Reply-To: <D865215C-0373-464C-BB7D-235ECAF16E49@kernel.org>
On Fri, Apr 25, 2025 at 08:40:23AM -0700, Kees Cook wrote:
> This isn't the case: the feature was explicitly designed in both GCC
> and Clang to not disrupt -Wuninitialized. But -Wuninitialized has been
> so flakey for so long that it is almost useless (there was even
> -Wmaybe-uninitialized added to try to cover some of the missed
> diagnostics).
I do remember a fair amount of bogus uninitialized variable warnings,
but they could be easily shut up without negative impact on the
code. Not getting any warnings at all on the other hand is catastrophic.
> And it's one of the many reasons stack variable zeroing
> is so important, since so much goes undiagnosed. :(
That only helps if the expected but forgotten initialization value
actually is zero.
prev parent reply other threads:[~2025-04-28 13:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 4:59 [PATCH] devtmpfs: don't use vfs_getattr_nosec to query i_mode Christoph Hellwig
2025-04-23 5:54 ` Christian Brauner
2025-04-23 6:42 ` Greg KH
2025-04-24 8:40 ` Christian Brauner
2025-04-23 6:45 ` Heiko Carstens
2025-04-24 5:07 ` Jain, Ayush
2025-04-24 8:41 ` Christian Brauner
2025-04-25 10:03 ` Heiko Carstens
2025-04-25 10:12 ` Christian Brauner
2025-04-25 13:32 ` Christoph Hellwig
2025-04-25 15:40 ` Kees Cook
2025-04-25 17:17 ` Nathan Chancellor
2025-04-28 13:15 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250428131530.GA30382@lst.de \
--to=hch@lst.de \
--cc=brauner@kernel.org \
--cc=dakr@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hca@linux.ibm.com \
--cc=kees@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
--cc=xni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).