From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E31925B1EE; Wed, 30 Apr 2025 11:05:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746011142; cv=none; b=XY5EV7g9Y1Uy8x0jvxWnOPRnP6utr3g8DHeKIJ2kP70spIk5pM2aNBwJe7fcbmsNwIJZxfpWz6ZPr7bWu8nRJh5Iumi2hrzH4KgzdUbOqlgf7zx60QE99dhiYpDrdr9cYawfO1FaKZfNiwCaOBe5kfRlHFiXKxJZjw61ELzO1FU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746011142; c=relaxed/simple; bh=sY3uIB6g6xsWBkS/M2/GrdpdnZH6W10Su5t41D1OTEg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=n0wRbIpA5FiDbgVXN4JhHl4fnKSmongyJ9w1RQf1gmmhx7a27YkBLnqgLTtGqBYVkHrbxkqMVX5VEPl7J5J97WnOM0ZiaxdR/efDnhie7ll55b8iDjjrd3Spx6KJdNBW4zAK7Jpah6nDgCgdw1Gews3Pa5WvkgjdJ+yd6BWID6U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=r3KvNqsM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="r3KvNqsM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B947C4CEE9; Wed, 30 Apr 2025 11:05:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746011141; bh=sY3uIB6g6xsWBkS/M2/GrdpdnZH6W10Su5t41D1OTEg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=r3KvNqsMuykJS/Cpmsgd2aTP1o5maZ8ZDPlmdNKJMeWDvV0bSld6O/UhOzsaVpV7i 0pyZPe2QwxhdFq+FmQVhKu4ruqypRFI0QKniEb98q9KuBtWEmDFEnWQnRlYiAT02Lz wXSTNdS+jJ1IsD6SN6wmMh9ciliDCp7vcicxwEcAVl2mlbIx+JL5cX5fkG+yjv81Oq cuy1ogEpYczms1AGvwwL0nvyt3Q1ajCZnILfajEQBtrY1M+Lm2DDDY7Tu64VXhAs9R AN0qeZ1cxp1QJZj3r8g0QnbmK8giPNnnkSsskl0tQnH8vs0RPgC8VRclzJInZCF+Iu 8xpEae28Uu5yw== From: Christian Brauner Date: Wed, 30 Apr 2025 13:05:02 +0200 Subject: [PATCH RFC 2/3] coredump: massage do_coredump() Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250430-work-coredump-socket-v1-2-2faf027dbb47@kernel.org> References: <20250430-work-coredump-socket-v1-0-2faf027dbb47@kernel.org> In-Reply-To: <20250430-work-coredump-socket-v1-0-2faf027dbb47@kernel.org> To: linux-fsdevel@vger.kernel.org Cc: "David S. Miller" , Alexander Viro , Daan De Meyer , David Rheinsberg , Eric Dumazet , Jakub Kicinski , Jan Kara , Kuniyuki Iwashima , Lennart Poettering , Luca Boccassi , Mike Yuan , Oleg Nesterov , Paolo Abeni , Simon Horman , =?utf-8?q?Zbigniew_J=C4=99drzejewski-Szmek?= , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Christian Brauner X-Mailer: b4 0.15-dev-c25d1 X-Developer-Signature: v=1; a=openpgp-sha256; l=4933; i=brauner@kernel.org; h=from:subject:message-id; bh=sY3uIB6g6xsWBkS/M2/GrdpdnZH6W10Su5t41D1OTEg=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMWQIMf+oXlKgxnJzTczzLauSNzBc4E7p/hSzUbmHOftF5 6KCK2kaHaUsDGJcDLJiiiwO7Sbhcst5KjYbZWrAzGFlAhnCwMUpABM5Yc3wz0zkyiN74dWuHo3r i5q7DL9c6BLoChSsi9b91MkzR+/mToY/HJIHHivc+JcSfN/xis8aZU27SKUW4+Ar/La2S7MPSUq zAgA= X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 We're going to extend the coredump code in follow-up patches. Clean it up so we can do this more easily. Signed-off-by: Christian Brauner --- fs/coredump.c | 123 +++++++++++++++++++++++++++++++--------------------------- 1 file changed, 66 insertions(+), 57 deletions(-) diff --git a/fs/coredump.c b/fs/coredump.c index 281320ea351f..1779299b8c61 100644 --- a/fs/coredump.c +++ b/fs/coredump.c @@ -646,63 +646,8 @@ void do_coredump(const kernel_siginfo_t *siginfo) goto fail_unlock; } - if (cn.core_type == COREDUMP_PIPE) { - int argi; - int dump_count; - char **helper_argv; - struct subprocess_info *sub_info; - - if (cprm.limit == 1) { - /* See umh_coredump_setup() which sets RLIMIT_CORE = 1. - * - * Normally core limits are irrelevant to pipes, since - * we're not writing to the file system, but we use - * cprm.limit of 1 here as a special value, this is a - * consistent way to catch recursive crashes. - * We can still crash if the core_pattern binary sets - * RLIM_CORE = !1, but it runs as root, and can do - * lots of stupid things. - * - * Note that we use task_tgid_vnr here to grab the pid - * of the process group leader. That way we get the - * right pid if a thread in a multi-threaded - * core_pattern process dies. - */ - coredump_report_failure("RLIMIT_CORE is set to 1, aborting core"); - goto fail_unlock; - } - cprm.limit = RLIM_INFINITY; - - dump_count = atomic_inc_return(&core_dump_count); - if (core_pipe_limit && (core_pipe_limit < dump_count)) { - coredump_report_failure("over core_pipe_limit, skipping core dump"); - goto fail_dropcount; - } - - helper_argv = kmalloc_array(argc + 1, sizeof(*helper_argv), - GFP_KERNEL); - if (!helper_argv) { - coredump_report_failure("%s failed to allocate memory", __func__); - goto fail_dropcount; - } - for (argi = 0; argi < argc; argi++) - helper_argv[argi] = cn.corename + argv[argi]; - helper_argv[argi] = NULL; - - retval = -ENOMEM; - sub_info = call_usermodehelper_setup(helper_argv[0], - helper_argv, NULL, GFP_KERNEL, - umh_coredump_setup, NULL, &cprm); - if (sub_info) - retval = call_usermodehelper_exec(sub_info, - UMH_WAIT_EXEC); - - kfree(helper_argv); - if (retval) { - coredump_report_failure("|%s pipe failed", cn.corename); - goto close_fail; - } - } else if (cn.core_type == COREDUMP_FILE) { + switch (cn.core_type) { + case COREDUMP_FILE: { struct mnt_idmap *idmap; struct inode *inode; int open_flags = O_CREAT | O_WRONLY | O_NOFOLLOW | @@ -796,6 +741,70 @@ void do_coredump(const kernel_siginfo_t *siginfo) if (do_truncate(idmap, cprm.file->f_path.dentry, 0, 0, cprm.file)) goto close_fail; + break; + } + case COREDUMP_PIPE: { + int argi; + int dump_count; + char **helper_argv; + struct subprocess_info *sub_info; + + if (cprm.limit == 1) { + /* See umh_coredump_setup() which sets RLIMIT_CORE = 1. + * + * Normally core limits are irrelevant to pipes, since + * we're not writing to the file system, but we use + * cprm.limit of 1 here as a special value, this is a + * consistent way to catch recursive crashes. + * We can still crash if the core_pattern binary sets + * RLIM_CORE = !1, but it runs as root, and can do + * lots of stupid things. + * + * Note that we use task_tgid_vnr here to grab the pid + * of the process group leader. That way we get the + * right pid if a thread in a multi-threaded + * core_pattern process dies. + */ + coredump_report_failure("RLIMIT_CORE is set to 1, aborting core"); + goto fail_unlock; + } + cprm.limit = RLIM_INFINITY; + + dump_count = atomic_inc_return(&core_dump_count); + if (core_pipe_limit && (core_pipe_limit < dump_count)) { + coredump_report_failure("over core_pipe_limit, skipping core dump"); + goto fail_dropcount; + } + + helper_argv = kmalloc_array(argc + 1, sizeof(*helper_argv), + GFP_KERNEL); + if (!helper_argv) { + coredump_report_failure("%s failed to allocate memory", __func__); + goto fail_dropcount; + } + for (argi = 0; argi < argc; argi++) + helper_argv[argi] = cn.corename + argv[argi]; + helper_argv[argi] = NULL; + + retval = -ENOMEM; + sub_info = call_usermodehelper_setup(helper_argv[0], + helper_argv, NULL, GFP_KERNEL, + umh_coredump_setup, NULL, &cprm); + if (sub_info) + retval = call_usermodehelper_exec(sub_info, + UMH_WAIT_EXEC); + + kfree(helper_argv); + if (retval) { + coredump_report_failure("|%s pipe failed", cn.corename); + goto close_fail; + } + break; + } + default: + WARN_ON_ONCE(true); + retval = -EINVAL; + goto close_fail; } /* get us an unshared descriptor table; almost always a no-op */ -- 2.47.2