From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: John Garry <john.g.garry@oracle.com>,
brauner@kernel.org, hch@lst.de, viro@zeniv.linux.org.uk,
jack@suse.cz, cem@kernel.org, linux-fsdevel@vger.kernel.org,
dchinner@redhat.com, linux-xfs@vger.kernel.org,
linux-kernel@vger.kernel.org, ojaswin@linux.ibm.com,
ritesh.list@gmail.com, martin.petersen@oracle.com,
linux-ext4@vger.kernel.org, linux-block@vger.kernel.org,
catherine.hoang@oracle.com, linux-api@vger.kernel.org
Subject: Re: [PATCH 16/15] xfs: only call xfs_setsize_buftarg once per buffer target
Date: Fri, 2 May 2025 08:57:26 +0200 [thread overview]
Message-ID: <20250502065726.GA8309@lst.de> (raw)
In-Reply-To: <20250501195208.GF25675@frogsfrogsfrogs>
On Thu, May 01, 2025 at 12:52:08PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> It's silly to call xfs_setsize_buftarg from xfs_alloc_buftarg with the
> block device LBA size because we don't need to ask the block layer to
> validate a geometry number that it provided us. Instead, set the
> preliminary bt_meta_sector* fields to the LBA size in preparation for
> reading the primary super.
>
> It's ok to lose the sync_blockdev call at buftarg creation time for the
> external log and rt devices because we don't read from them until after
> calling xfs_setup_devices. We do need an explicit sync for the data
> device because we read the primary super before calling
> xfs_setup_devices.
Should we just it for all of them in open_devices now that the sync
is decoupled from setting the block size?
Otherwise this looks good, but I guess this should go before the atomic
writes series in the end?
next prev parent reply other threads:[~2025-05-02 6:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-01 16:57 [PATCH v10 00/15] large atomic writes for xfs John Garry
2025-05-01 16:57 ` [PATCH v10 01/15] fs: add atomic write unit max opt to statx John Garry
2025-05-02 20:12 ` [PATCH v10.1 1.1/15] xfs: only call xfs_setsize_buftarg once per buffer target Darrick J. Wong
2025-05-01 16:57 ` [PATCH v10 02/15] xfs: add helpers to compute log item overhead John Garry
2025-05-01 16:57 ` [PATCH v10 03/15] xfs: add helpers to compute transaction reservation for finishing intent items John Garry
2025-05-01 16:57 ` [PATCH v10 04/15] xfs: rename xfs_inode_can_atomicwrite() -> xfs_inode_can_hw_atomic_write() John Garry
2025-05-01 16:57 ` [PATCH v10 05/15] xfs: ignore HW which cannot atomic write a single block John Garry
2025-05-02 20:13 ` [PATCH v10.1 " Darrick J. Wong
2025-05-01 16:57 ` [PATCH v10 06/15] xfs: allow block allocator to take an alignment hint John Garry
2025-05-01 16:57 ` [PATCH v10 07/15] xfs: refactor xfs_reflink_end_cow_extent() John Garry
2025-05-01 16:57 ` [PATCH v10 08/15] xfs: refine atomic write size check in xfs_file_write_iter() John Garry
2025-05-01 16:57 ` [PATCH v10 09/15] xfs: add xfs_atomic_write_cow_iomap_begin() John Garry
2025-05-01 16:57 ` [PATCH v10 10/15] xfs: add large atomic writes checks in xfs_direct_write_iomap_begin() John Garry
2025-05-01 16:57 ` [PATCH v10 11/15] xfs: commit CoW-based atomic writes atomically John Garry
2025-05-01 16:57 ` [PATCH v10 12/15] xfs: add xfs_file_dio_write_atomic() John Garry
2025-05-01 16:57 ` [PATCH v10 13/15] xfs: add xfs_calc_atomic_write_unit_max() John Garry
2025-05-05 5:22 ` Darrick J. Wong
2025-05-01 16:57 ` [PATCH v10 14/15] xfs: update atomic write limits John Garry
2025-05-01 16:57 ` [PATCH v10 15/15] xfs: allow sysadmins to specify a maximum atomic write limit at mount time John Garry
2025-05-01 19:52 ` [PATCH 16/15] xfs: only call xfs_setsize_buftarg once per buffer target Darrick J. Wong
2025-05-02 6:57 ` Christoph Hellwig [this message]
2025-05-02 16:44 ` Darrick J. Wong
2025-05-01 19:53 ` [PATCH 17/15] xfs: move buftarg atomic write geometry config to setsize_buftarg Darrick J. Wong
2025-05-02 6:58 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250502065726.GA8309@lst.de \
--to=hch@lst.de \
--cc=brauner@kernel.org \
--cc=catherine.hoang@oracle.com \
--cc=cem@kernel.org \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=jack@suse.cz \
--cc=john.g.garry@oracle.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).