From: Steven Rostedt <rostedt@goodmis.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org,
Christian Brauner <brauner@kernel.org>
Subject: Re: [PATCH v2] kill vfs_submount()
Date: Mon, 5 May 2025 20:19:04 -0400 [thread overview]
Message-ID: <20250505201904.59cd46d0@gandalf.local.home> (raw)
In-Reply-To: <20250505213829.GI2023217@ZenIV>
On Mon, 5 May 2025 22:38:29 +0100
Al Viro <viro@zeniv.linux.org.uk> wrote:
> @@ -10084,10 +10087,20 @@ static struct vfsmount *trace_automount(struct dentry *mntpt, void *ingore)
> type = get_fs_type("tracefs");
> if (!type)
> return NULL;
> - mnt = vfs_submount(mntpt, type, "tracefs", NULL);
> +
> + fc = fs_context_for_submount(type, mntpt);
> put_filesystem(type);
> - if (IS_ERR(mnt))
> - return NULL;
> + if (IS_ERR(fc))
> + return ERR_CAST(fc);
> +
> + ret = vfs_parse_fs_string(fc, "source",
> + "tracefs", strlen("tracefs"));
> + if (!ret)
> + mnt = fc_mount(fc);
> + else
> + mnt = ERR_PTR(ret);
> +
> + put_fs_context(fc);
> return mnt;
> }
>
In case others try to apply this on Linus or linux-next, this is based on top of:
https://lore.kernel.org/all/20250424060845.GG2023217@ZenIV/
Otherwise it doesn't apply cleanly.
Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Tested-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-- Steve
next prev parent reply other threads:[~2025-05-06 0:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-03 21:29 [PATCH][RFC][CFT] kill vfs_submount(), already Al Viro
2025-05-05 10:55 ` Jan Kara
2025-05-05 21:38 ` [PATCH v2] kill vfs_submount() Al Viro
2025-05-05 22:00 ` Al Viro
2025-05-06 0:19 ` Steven Rostedt [this message]
2025-05-06 10:57 ` Jan Kara
2025-05-05 13:57 ` [PATCH][RFC][CFT] kill vfs_submount(), already Christian Brauner
2025-05-05 14:15 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250505201904.59cd46d0@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox