From: Joanne Koong <joannelkoong@gmail.com>
To: miklos@szeredi.hu
Cc: linux-fsdevel@vger.kernel.org, bernd.schubert@fastmail.fm,
jlayton@kernel.org, jefflexu@linux.alibaba.com,
josef@toxicpanda.com, willy@infradead.org, kernel-team@meta.com
Subject: [PATCH v6 04/11] fuse: support large folios for writethrough writes
Date: Mon, 12 May 2025 15:58:33 -0700 [thread overview]
Message-ID: <20250512225840.826249-5-joannelkoong@gmail.com> (raw)
In-Reply-To: <20250512225840.826249-1-joannelkoong@gmail.com>
Add support for folios larger than one page size for writethrough
writes.
Signed-off-by: Joanne Koong <joannelkoong@gmail.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
---
fs/fuse/file.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index 6b77daa2fbce..2d9bc484e87a 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -1146,7 +1146,8 @@ static ssize_t fuse_fill_write_pages(struct fuse_io_args *ia,
size_t tmp;
struct folio *folio;
pgoff_t index = pos >> PAGE_SHIFT;
- unsigned bytes = min(PAGE_SIZE - offset, num);
+ unsigned int bytes;
+ unsigned int folio_offset;
again:
folio = __filemap_get_folio(mapping, index, FGP_WRITEBEGIN,
@@ -1159,7 +1160,10 @@ static ssize_t fuse_fill_write_pages(struct fuse_io_args *ia,
if (mapping_writably_mapped(mapping))
flush_dcache_folio(folio);
- tmp = copy_folio_from_iter_atomic(folio, offset, bytes, ii);
+ folio_offset = ((index - folio->index) << PAGE_SHIFT) + offset;
+ bytes = min(folio_size(folio) - folio_offset, num);
+
+ tmp = copy_folio_from_iter_atomic(folio, folio_offset, bytes, ii);
flush_dcache_folio(folio);
if (!tmp) {
@@ -1179,6 +1183,7 @@ static ssize_t fuse_fill_write_pages(struct fuse_io_args *ia,
}
ap->folios[ap->num_folios] = folio;
+ ap->descs[ap->num_folios].offset = folio_offset;
ap->descs[ap->num_folios].length = tmp;
ap->num_folios++;
@@ -1186,11 +1191,11 @@ static ssize_t fuse_fill_write_pages(struct fuse_io_args *ia,
pos += tmp;
num -= tmp;
offset += tmp;
- if (offset == PAGE_SIZE)
+ if (offset == folio_size(folio))
offset = 0;
- /* If we copied full page, mark it uptodate */
- if (tmp == PAGE_SIZE)
+ /* If we copied full folio, mark it uptodate */
+ if (tmp == folio_size(folio))
folio_mark_uptodate(folio);
if (folio_test_uptodate(folio)) {
--
2.47.1
next prev parent reply other threads:[~2025-05-12 22:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-12 22:58 [PATCH v6 00/11] fuse: support large folios Joanne Koong
2025-05-12 22:58 ` [PATCH v6 01/11] fuse: support copying " Joanne Koong
2025-05-14 0:18 ` Matthew Wilcox
2025-05-14 22:59 ` Joanne Koong
2025-05-15 2:05 ` Matthew Wilcox
2025-05-15 18:50 ` Joanne Koong
2025-05-15 8:26 ` Miklos Szeredi
2025-05-15 17:53 ` Joanne Koong
2025-05-16 9:47 ` Miklos Szeredi
2025-05-12 22:58 ` [PATCH v6 02/11] fuse: support large folios for retrieves Joanne Koong
2025-05-12 22:58 ` [PATCH v6 03/11] fuse: refactor fuse_fill_write_pages() Joanne Koong
2025-05-12 22:58 ` Joanne Koong [this message]
2025-05-12 22:58 ` [PATCH v6 05/11] fuse: support large folios for folio reads Joanne Koong
2025-05-12 22:58 ` [PATCH v6 06/11] fuse: support large folios for symlinks Joanne Koong
2025-05-12 22:58 ` [PATCH v6 07/11] fuse: support large folios for stores Joanne Koong
2025-05-12 22:58 ` [PATCH v6 08/11] fuse: support large folios for queued writes Joanne Koong
2025-05-12 22:58 ` [PATCH v6 09/11] fuse: support large folios for readahead Joanne Koong
2025-05-12 22:58 ` [PATCH v6 10/11] fuse: optimize direct io large folios processing Joanne Koong
2025-05-13 7:19 ` Miklos Szeredi
2025-05-13 20:39 ` Joanne Koong
2025-05-15 8:27 ` Miklos Szeredi
2025-05-12 22:58 ` [PATCH v6 11/11] fuse: support large folios for writeback Joanne Koong
2025-05-13 7:32 ` [PATCH v6 00/11] fuse: support large folios Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250512225840.826249-5-joannelkoong@gmail.com \
--to=joannelkoong@gmail.com \
--cc=bernd.schubert@fastmail.fm \
--cc=jefflexu@linux.alibaba.com \
--cc=jlayton@kernel.org \
--cc=josef@toxicpanda.com \
--cc=kernel-team@meta.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).