* [PATCH] fuse: remove unneeded offset assignment when filling write pages
@ 2025-05-20 20:16 Joanne Koong
2025-07-02 5:23 ` Miklos Szeredi
0 siblings, 1 reply; 2+ messages in thread
From: Joanne Koong @ 2025-05-20 20:16 UTC (permalink / raw)
To: miklos; +Cc: linux-fsdevel
With the change in aee03ea7ff98 ("fuse: support large folios for
writethrough writes"), this old line for setting ap->descs[0].offset is
now obsolete and unneeded. This should have been removed as part of
aee03ea7ff98.
Signed-off-by: Joanne Koong <joannelkoong@gmail.com>
Fixes: aee03ea7ff98 ("fuse: support large folios for writethrough writes")
---
fs/fuse/file.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index 3d0b33be3824..5bd08f231221 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -1160,7 +1160,6 @@ static ssize_t fuse_fill_write_pages(struct fuse_io_args *ia,
num = min(num, max_pages << PAGE_SHIFT);
ap->args.in_pages = true;
- ap->descs[0].offset = offset;
while (num) {
size_t tmp;
--
2.47.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fuse: remove unneeded offset assignment when filling write pages
2025-05-20 20:16 [PATCH] fuse: remove unneeded offset assignment when filling write pages Joanne Koong
@ 2025-07-02 5:23 ` Miklos Szeredi
0 siblings, 0 replies; 2+ messages in thread
From: Miklos Szeredi @ 2025-07-02 5:23 UTC (permalink / raw)
To: Joanne Koong; +Cc: linux-fsdevel
On Tue, 20 May 2025 at 22:18, Joanne Koong <joannelkoong@gmail.com> wrote:
>
> With the change in aee03ea7ff98 ("fuse: support large folios for
> writethrough writes"), this old line for setting ap->descs[0].offset is
> now obsolete and unneeded. This should have been removed as part of
> aee03ea7ff98.
>
> Signed-off-by: Joanne Koong <joannelkoong@gmail.com>
> Fixes: aee03ea7ff98 ("fuse: support large folios for writethrough writes")
Applied, thanks.
Miklos
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-07-02 5:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-20 20:16 [PATCH] fuse: remove unneeded offset assignment when filling write pages Joanne Koong
2025-07-02 5:23 ` Miklos Szeredi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).