From: Al Viro <viro@zeniv.linux.org.uk>
To: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>
Cc: "frank.li@vivo.com" <frank.li@vivo.com>,
"glaubitz@physik.fu-berlin.de" <glaubitz@physik.fu-berlin.de>,
"slava@dubeyko.com" <slava@dubeyko.com>,
"ernesto.mnd.fernandez@gmail.com"
<ernesto.mnd.fernandez@gmail.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"syzbot+8c0bc9f818702ff75b76@syzkaller.appspotmail.com"
<syzbot+8c0bc9f818702ff75b76@syzkaller.appspotmail.com>
Subject: Re: [PATCH v2] hfsplus: remove mutex_lock check in hfsplus_free_extents
Date: Thu, 29 May 2025 19:36:43 +0100 [thread overview]
Message-ID: <20250529183643.GM2023217@ZenIV> (raw)
In-Reply-To: <2f17f8d98232dec938bc9e7085a73921444cdb33.camel@ibm.com>
On Thu, May 29, 2025 at 06:34:43PM +0000, Viacheslav Dubeyko wrote:
> > diff --git a/fs/hfsplus/extents.c b/fs/hfsplus/extents.c
> > index a6d61685ae79..b1699b3c246a 100644
> > --- a/fs/hfsplus/extents.c
> > +++ b/fs/hfsplus/extents.c
> > @@ -342,9 +342,6 @@ static int hfsplus_free_extents(struct super_block *sb,
> > int i;
> > int err = 0;
> >
> > - /* Mapping the allocation file may lock the extent tree */
> > - WARN_ON(mutex_is_locked(&HFSPLUS_SB(sb)->ext_tree->tree_lock));
> > -
>
> Makes sense to me. Looks good.
>
> But I really like your mentioning of reproducing the issue in generic/013 and
> really nice analysis of the issue there. Sadly, we haven't it in the comment. :)
Umm... *Is* that thing safe to call without that lock?
next prev parent reply other threads:[~2025-05-29 18:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-29 6:18 [PATCH v2] hfsplus: remove mutex_lock check in hfsplus_free_extents Yangtao Li
2025-05-29 10:34 ` wangjianjian (C)
2025-05-29 10:46 ` Yangtao Li
2025-05-30 1:20 ` wangjianjian (C)
2025-05-29 18:34 ` Viacheslav Dubeyko
2025-05-29 18:36 ` Al Viro [this message]
2025-05-29 18:48 ` Viacheslav Dubeyko
2025-05-30 2:47 ` Yangtao Li
2025-05-30 2:41 ` Yangtao Li
2025-06-06 23:04 ` Viacheslav Dubeyko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250529183643.GM2023217@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=Slava.Dubeyko@ibm.com \
--cc=akpm@linux-foundation.org \
--cc=ernesto.mnd.fernandez@gmail.com \
--cc=frank.li@vivo.com \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=slava@dubeyko.com \
--cc=syzbot+8c0bc9f818702ff75b76@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).