From: wangtao <tao.wangtao@honor.com>
To: <sumit.semwal@linaro.org>, <christian.koenig@amd.com>,
<kraxel@redhat.com>, <vivek.kasireddy@intel.com>,
<viro@zeniv.linux.org.uk>, <brauner@kernel.org>,
<hughd@google.com>, <akpm@linux-foundation.org>,
<amir73il@gmail.com>
Cc: <benjamin.gaignard@collabora.com>, <Brian.Starkey@arm.com>,
<jstultz@google.com>, <tjmercier@google.com>, <jack@suse.cz>,
<baolin.wang@linux.alibaba.com>, <linux-media@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>,
<linaro-mm-sig@lists.linaro.org>, <linux-kernel@vger.kernel.org>,
<linux-fsdevel@vger.kernel.org>, <linux-mm@kvack.org>,
<bintian.wang@honor.com>, <yipengxiang@honor.com>,
<liulu.liu@honor.com>, <feng.han@honor.com>,
wangtao <tao.wangtao@honor.com>
Subject: [PATCH v4 4/4] dmabuf:system_heap Implement system_heap dmabuf direct I/O
Date: Tue, 3 Jun 2025 17:52:45 +0800 [thread overview]
Message-ID: <20250603095245.17478-5-tao.wangtao@honor.com> (raw)
In-Reply-To: <20250603095245.17478-1-tao.wangtao@honor.com>
First verify system_heap exporter has exclusive dmabuf access.
Build bio_vec from sgtable, then invoke target file's r/w callbacks for IO.
Outperforms buffer IO mmap/read by 250%, beats direct I/O udmabuf
copy_file_range by over 30% with initialization time significantly lower
than udmabuf.
Test data:
| 32x32MB Read 1024MB |Creat-ms|Close-ms| I/O-ms|I/O-MB/s| I/O%
|-------------------------|--------|--------|--------|--------|-----
| 1)Beg dmabuf buffer R/W| 47 | 5 | 1125 | 954 | 100%
| 2) udmabuf buffer R/W| 576 | 323 | 1228 | 874 | 91%
| 3) udma+memfd buffer R/W| 596 | 340 | 2166 | 495 | 51%
| 4) udma+memfd direct R/W| 570 | 338 | 711 | 1510 | 158%
| 5) udmabuf buffer c_f_r| 578 | 329 | 1128 | 952 | 99%
| 6) udmabuf direct c_f_r| 570 | 324 | 405 | 2651 | 277%
| 7) dmabuf buffer c_f_r| 47 | 5 | 1035 | 1037 | 108%
| 8) dmabuf direct c_f_r| 51 | 5 | 309 | 3480 | 364%
| 9)End dmabuf buffer R/W| 48 | 5 | 1153 | 931 | 97%
| 32x32MB Write 1024MB |Creat-ms|Close-ms| I/O-ms|I/O-MB/s| I/O%
|-------------------------|--------|--------|--------|--------|-----
| 1)Beg dmabuf buffer R/W| 50 | 5 | 1405 | 764 | 100%
| 2) udmabuf buffer R/W| 580 | 341 | 1337 | 803 | 105%
| 3) udma+memfd buffer R/W| 588 | 331 | 1820 | 590 | 77%
| 4) udma+memfd direct R/W| 585 | 333 | 662 | 1622 | 212%
| 5) udmabuf buffer c_f_r| 577 | 329 | 1326 | 810 | 106%
| 6) udmabuf direct c_f_r| 580 | 330 | 602 | 1784 | 233%
| 7) dmabuf buffer c_f_r| 49 | 5 | 1330 | 807 | 105%
| 8) dmabuf direct c_f_r| 49 | 5 | 344 | 3127 | 409%
| 9)End dmabuf buffer R/W| 50 | 5 | 1442 | 745 | 97%
Signed-off-by: wangtao <tao.wangtao@honor.com>
---
drivers/dma-buf/heaps/system_heap.c | 69 +++++++++++++++++++++++++++++
1 file changed, 69 insertions(+)
diff --git a/drivers/dma-buf/heaps/system_heap.c b/drivers/dma-buf/heaps/system_heap.c
index 26d5dc89ea16..85ffff7ef855 100644
--- a/drivers/dma-buf/heaps/system_heap.c
+++ b/drivers/dma-buf/heaps/system_heap.c
@@ -20,6 +20,8 @@
#include <linux/scatterlist.h>
#include <linux/slab.h>
#include <linux/vmalloc.h>
+#include <linux/bvec.h>
+#include <linux/uio.h>
static struct dma_heap *sys_heap;
@@ -281,6 +283,70 @@ static void system_heap_vunmap(struct dma_buf *dmabuf, struct iosys_map *map)
iosys_map_clear(map);
}
+static ssize_t system_heap_buffer_rw_other(struct system_heap_buffer *buffer,
+ loff_t my_pos, struct file *other, loff_t pos,
+ size_t count, bool is_write)
+{
+ struct sg_table *sgt = &buffer->sg_table;
+ struct scatterlist *sg;
+ loff_t my_end = my_pos + count, bv_beg, bv_end = 0;
+ size_t i, bv_off, bv_len, bv_idx = 0;
+ struct bio_vec *bvec;
+ struct kiocb kiocb;
+ struct iov_iter iter;
+ unsigned int direction = is_write ? ITER_SOURCE : ITER_DEST;
+ ssize_t ret = 0;
+
+ bvec = kvcalloc(sgt->orig_nents, sizeof(*bvec), GFP_KERNEL);
+ if (!bvec)
+ return -ENOMEM;
+
+ init_sync_kiocb(&kiocb, other);
+ kiocb.ki_pos = pos;
+
+ for_each_sgtable_sg(sgt, sg, i) {
+ bv_beg = bv_end;
+ if (bv_beg >= my_end)
+ break;
+ bv_end += sg->offset + sg->length;
+ if (bv_end <= my_pos)
+ continue;
+
+ bv_len = min(bv_end, my_end) - max(my_pos, bv_beg);
+ bv_off = sg->offset + (my_pos > bv_beg ? my_pos - bv_beg : 0);
+ bvec_set_page(&bvec[bv_idx], sg_page(sg), bv_len, bv_off);
+ ++bv_idx;
+ }
+
+ if (bv_idx > 0) {
+ /* start R/W. */
+ iov_iter_bvec(&iter, direction, bvec, bv_idx, count);
+ if (is_write)
+ ret = other->f_op->write_iter(&kiocb, &iter);
+ else
+ ret = other->f_op->read_iter(&kiocb, &iter);
+ }
+ kvfree(bvec);
+
+ return ret;
+}
+
+static ssize_t system_heap_dma_buf_rw_file(struct dma_buf *dmabuf,
+ loff_t my_pos, struct file *file, loff_t pos,
+ size_t count, bool is_write)
+{
+ struct system_heap_buffer *buffer = dmabuf->priv;
+ ssize_t ret = -EBUSY;
+
+ mutex_lock(&buffer->lock);
+ if (list_empty(&buffer->attachments) && !buffer->vmap_cnt)
+ ret = system_heap_buffer_rw_other(buffer, my_pos,
+ file, pos, count, is_write);
+ mutex_unlock(&buffer->lock);
+
+ return ret;
+}
+
static void system_heap_dma_buf_release(struct dma_buf *dmabuf)
{
struct system_heap_buffer *buffer = dmabuf->priv;
@@ -308,6 +374,7 @@ static const struct dma_buf_ops system_heap_buf_ops = {
.mmap = system_heap_mmap,
.vmap = system_heap_vmap,
.vunmap = system_heap_vunmap,
+ .rw_file = system_heap_dma_buf_rw_file,
.release = system_heap_dma_buf_release,
};
@@ -400,6 +467,8 @@ static struct dma_buf *system_heap_allocate(struct dma_heap *heap,
ret = PTR_ERR(dmabuf);
goto free_pages;
}
+ /* Support direct I/O */
+ dmabuf->file->f_mode |= FMODE_CAN_ODIRECT;
return dmabuf;
free_pages:
--
2.17.1
next prev parent reply other threads:[~2025-06-03 9:53 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-03 9:52 [PATCH v4 0/4] Implement dmabuf direct I/O via copy_file_range wangtao
2025-06-03 9:52 ` [PATCH v4 1/4] fs: allow cross-FS copy_file_range for memory file with direct I/O wangtao
2025-06-03 10:56 ` Amir Goldstein
2025-06-03 12:38 ` wangtao
2025-06-03 12:43 ` Amir Goldstein
2025-06-03 9:52 ` [PATCH v4 2/4] dmabuf: Implement copy_file_range callback for dmabuf direct I/O prep wangtao
2025-06-03 10:42 ` Christian König
2025-06-03 12:26 ` wangtao
2025-06-03 13:04 ` Christoph Hellwig
2025-06-03 9:52 ` [PATCH v4 3/4] udmabuf: Implement udmabuf direct I/O wangtao
2025-06-03 9:52 ` wangtao [this message]
2025-06-03 13:00 ` [PATCH v4 0/4] Implement dmabuf direct I/O via copy_file_range Christoph Hellwig
2025-06-03 13:14 ` Christian König
2025-06-03 13:19 ` Christoph Hellwig
2025-06-03 14:18 ` Christian König
2025-06-03 14:28 ` Christoph Hellwig
2025-06-03 15:55 ` Christian König
2025-06-03 16:01 ` Christoph Hellwig
2025-06-06 9:59 ` wangtao
2025-06-06 9:52 ` wangtao
2025-06-06 11:20 ` Christian König
2025-06-09 4:35 ` Christoph Hellwig
2025-06-09 9:32 ` wangtao
2025-06-10 10:52 ` Christian König
2025-06-10 13:37 ` Christoph Hellwig
2025-06-13 9:43 ` wangtao
2025-06-16 5:24 ` Christoph Hellwig
2025-06-10 13:34 ` Christoph Hellwig
2025-06-13 9:33 ` wangtao
2025-06-16 5:25 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250603095245.17478-5-tao.wangtao@honor.com \
--to=tao.wangtao@honor.com \
--cc=Brian.Starkey@arm.com \
--cc=akpm@linux-foundation.org \
--cc=amir73il@gmail.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=benjamin.gaignard@collabora.com \
--cc=bintian.wang@honor.com \
--cc=brauner@kernel.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=feng.han@honor.com \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=jstultz@google.com \
--cc=kraxel@redhat.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liulu.liu@honor.com \
--cc=sumit.semwal@linaro.org \
--cc=tjmercier@google.com \
--cc=viro@zeniv.linux.org.uk \
--cc=vivek.kasireddy@intel.com \
--cc=yipengxiang@honor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).