From: Christian Brauner <brauner@kernel.org>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
Miklos Szeredi <miklos@szeredi.hu>,
linux-fsdevel@vger.kernel.org, NeilBrown <neil@brown.name>
Subject: Re: [PATCH] ovl: fix regression caused for lookup helpers API changes
Date: Thu, 5 Jun 2025 13:50:03 +0200 [thread overview]
Message-ID: <20250605-futter-harfe-67c3532e6021@brauner> (raw)
In-Reply-To: <CAOQ4uxgf+0B5vy1ObhLqeRNmW8JzdotqHAwG7qS3xBZmfAABvQ@mail.gmail.com>
On Thu, Jun 05, 2025 at 01:14:20PM +0200, Amir Goldstein wrote:
> On Thu, Jun 5, 2025 at 1:00 PM Christian Brauner <brauner@kernel.org> wrote:
> >
> > On Thu, 05 Jun 2025 12:15:30 +0200, Amir Goldstein wrote:
> > > The lookup helpers API was changed by merge of vfs-6.16-rc1.async.dir to
> > > pass a non-const qstr pointer argument to lookup_one*() helpers.
> > >
> > > All of the callers of this API were changed to pass a pointer to temp
> > > copy of qstr, except overlays that was passing a const pointer to
> > > dentry->d_name that was changed to pass a non-const copy instead
> > > when doing a lookup in lower layer which is not the fs of said dentry.
> > >
> > > [...]
> >
> > Applied to the vfs.fixes branch of the vfs/vfs.git tree.
> > Patches in the vfs.fixes branch should appear in linux-next soon.
> >
>
> Could you fix the grammatical mistake in my commit title:
>
> s/caused for/caused by/
Already done including the ones in the comments to your fix. ;)
next prev parent reply other threads:[~2025-06-05 11:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 10:15 [PATCH] ovl: fix regression caused for lookup helpers API changes Amir Goldstein
2025-06-05 11:00 ` Christian Brauner
2025-06-05 11:14 ` Amir Goldstein
2025-06-05 11:50 ` Christian Brauner [this message]
2025-06-07 10:56 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250605-futter-harfe-67c3532e6021@brauner \
--to=brauner@kernel.org \
--cc=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=neil@brown.name \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox