From: Andrew Morton <akpm@linux-foundation.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: wangzijie <wangzijie1@honor.com>,
adobriyan@gmail.com, ast@kernel.org,
kirill.shutemov@linux.intel.com, linux-fsdevel@vger.kernel.org,
rick.p.edgecombe@intel.com
Subject: Re: [PATCH] proc: clear FMODE_LSEEK flag correctly for permanent pde
Date: Thu, 5 Jun 2025 21:01:21 -0700 [thread overview]
Message-ID: <20250605210121.5c5f53cbd4deb1df032e73cc@linux-foundation.org> (raw)
In-Reply-To: <20250606035714.GP299672@ZenIV>
On Fri, 6 Jun 2025 04:57:14 +0100 Al Viro <viro@zeniv.linux.org.uk> wrote:
> * why is that earlier patch sitting someplace that is *NOT*
> in -next?
I recently tenitatively added it to mm.git and haven't pushed that out
yet.
> * why bother with those games at all? Just nick another bit
> from pde->flags (let's call it PROC_ENTRY_proc_lseek for consistency
> sake), set it in same pde_set_flags() where other flags are dealt with
> and just turn that thing into
> if (!pde_has_proc_lseek(pde))
> file->f_mode &= ~FMODE_LSEEK;
> leaving it where it is. Less intrusive and easier to follow...
Thanks, I'll drop both patches.
next prev parent reply other threads:[~2025-06-06 4:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 6:52 [PATCH] proc: clear FMODE_LSEEK flag correctly for permanent pde wangzijie
2025-06-05 21:44 ` Andrew Morton
2025-06-06 1:56 ` Al Viro
2025-06-06 2:37 ` wangzijie
2025-06-06 3:57 ` Al Viro
2025-06-06 4:01 ` Andrew Morton [this message]
2025-06-06 5:13 ` wangzijie
2025-06-06 3:34 ` wangzijie
2025-06-06 3:44 ` Andrew Morton
2025-06-06 3:58 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250605210121.5c5f53cbd4deb1df032e73cc@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adobriyan@gmail.com \
--cc=ast@kernel.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=rick.p.edgecombe@intel.com \
--cc=viro@zeniv.linux.org.uk \
--cc=wangzijie1@honor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox