From: Song Liu <song@kernel.org>
To: bpf@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org
Cc: kernel-team@meta.com, andrii@kernel.org, eddyz87@gmail.com,
ast@kernel.org, daniel@iogearbox.net, martin.lau@linux.dev,
viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz,
kpsingh@kernel.org, mattbobrowski@google.com, amir73il@gmail.com,
repnop@google.com, jlayton@kernel.org, josef@toxicpanda.com,
mic@digikod.net, gnoack@google.com, m@maowtm.org,
Song Liu <song@kernel.org>
Subject: [PATCH v3 bpf-next 1/5] namei: Introduce new helper function path_walk_parent()
Date: Fri, 6 Jun 2025 14:30:11 -0700 [thread overview]
Message-ID: <20250606213015.255134-2-song@kernel.org> (raw)
In-Reply-To: <20250606213015.255134-1-song@kernel.org>
This helper walks an input path to its parent. Logic are added to handle
walking across mount tree.
This will be used by landlock, and BPF LSM.
Signed-off-by: Song Liu <song@kernel.org>
---
fs/namei.c | 51 +++++++++++++++++++++++++++++++++++++++++++
include/linux/namei.h | 2 ++
2 files changed, 53 insertions(+)
diff --git a/fs/namei.c b/fs/namei.c
index 4bb889fc980b..f02183e9c073 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -1424,6 +1424,57 @@ static bool choose_mountpoint(struct mount *m, const struct path *root,
return found;
}
+/**
+ * path_walk_parent - Walk to the parent of path
+ * @path: input and output path.
+ * @root: root of the path walk, do not go beyond this root. If @root is
+ * zero'ed, walk all the way to real root.
+ *
+ * Given a path, find the parent path. Replace @path with the parent path.
+ * If we were already at the real root or a disconnected root, @path is
+ * not changed.
+ *
+ * The logic of path_walk_parent() is similar to follow_dotdot(), except
+ * that path_walk_parent() will continue walking for !path_connected case.
+ * This effectively means we are walking from disconnected bind mount to
+ * the original mount. If this behavior is not desired, the caller can add
+ * a check like:
+ *
+ * if (path_walk_parent(&path) && !path_connected(path.mnt, path.dentry)
+ * // continue walking
+ * else
+ * // stop walking
+ *
+ * Returns:
+ * true - if @path is updated to its parent.
+ * false - if @path is already the root (real root or @root).
+ */
+bool path_walk_parent(struct path *path, const struct path *root)
+{
+ struct dentry *parent;
+
+ if (path_equal(path, root))
+ return false;
+
+ if (unlikely(path->dentry == path->mnt->mnt_root)) {
+ struct path p;
+
+ if (!choose_mountpoint(real_mount(path->mnt), root, &p))
+ return false;
+ path_put(path);
+ *path = p;
+ }
+
+ if (unlikely(IS_ROOT(path->dentry)))
+ return false;
+
+ parent = dget_parent(path->dentry);
+ dput(path->dentry);
+ path->dentry = parent;
+ return true;
+}
+EXPORT_SYMBOL_GPL(path_walk_parent);
+
/*
* Perform an automount
* - return -EISDIR to tell follow_managed() to stop and return the path we
diff --git a/include/linux/namei.h b/include/linux/namei.h
index 5d085428e471..cba5373ecf86 100644
--- a/include/linux/namei.h
+++ b/include/linux/namei.h
@@ -85,6 +85,8 @@ extern int follow_down_one(struct path *);
extern int follow_down(struct path *path, unsigned int flags);
extern int follow_up(struct path *);
+bool path_walk_parent(struct path *path, const struct path *root);
+
extern struct dentry *lock_rename(struct dentry *, struct dentry *);
extern struct dentry *lock_rename_child(struct dentry *, struct dentry *);
extern void unlock_rename(struct dentry *, struct dentry *);
--
2.47.1
next prev parent reply other threads:[~2025-06-06 21:30 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-06 21:30 [PATCH v3 bpf-next 0/5] bpf path iterator Song Liu
2025-06-06 21:30 ` Song Liu [this message]
2025-06-10 17:18 ` [PATCH v3 bpf-next 1/5] namei: Introduce new helper function path_walk_parent() Mickaël Salaün
2025-06-10 17:26 ` Song Liu
2025-06-10 22:26 ` Tingmao Wang
2025-06-10 22:34 ` Tingmao Wang
2025-06-10 23:08 ` Song Liu
2025-06-11 0:23 ` Tingmao Wang
2025-06-10 23:34 ` NeilBrown
2025-06-11 0:56 ` Song Liu
2025-06-11 15:42 ` Mickaël Salaün
2025-06-11 16:31 ` Song Liu
2025-06-11 17:50 ` Tingmao Wang
2025-06-11 18:08 ` Song Liu
2025-06-12 9:01 ` Jan Kara
2025-06-12 9:49 ` Jan Kara
2025-06-12 12:31 ` Christian Brauner
2025-06-16 0:24 ` Ref-less parent walk from Landlock (was: Re: [PATCH v3 bpf-next 1/5] namei: Introduce new helper function path_walk_parent()) Tingmao Wang
2025-06-17 6:20 ` Song Liu
2025-06-06 21:30 ` [PATCH v3 bpf-next 2/5] landlock: Use path_walk_parent() Song Liu
2025-06-08 18:45 ` Tingmao Wang
2025-06-06 21:30 ` [PATCH v3 bpf-next 3/5] bpf: Introduce path iterator Song Liu
2025-06-06 21:30 ` [PATCH v3 bpf-next 4/5] selftests/bpf: Add tests for bpf " Song Liu
2025-06-06 21:30 ` [PATCH v3 bpf-next 5/5] selftests/bpf: Path walk test Song Liu
2025-06-08 17:32 ` [PATCH v3 bpf-next 0/5] bpf path iterator Tingmao Wang
2025-06-09 6:23 ` Song Liu
2025-06-09 8:08 ` Tingmao Wang
2025-06-11 11:36 ` Christian Brauner
2025-06-11 15:39 ` Mickaël Salaün
2025-06-08 17:32 ` Tingmao Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250606213015.255134-2-song@kernel.org \
--to=song@kernel.org \
--cc=amir73il@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=gnoack@google.com \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=josef@toxicpanda.com \
--cc=kernel-team@meta.com \
--cc=kpsingh@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=m@maowtm.org \
--cc=martin.lau@linux.dev \
--cc=mattbobrowski@google.com \
--cc=mic@digikod.net \
--cc=repnop@google.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).