From: NeilBrown <neil@brown.name>
To: Namjae Jeon <linkinjeon@kernel.org>,
Steve French <smfrench@gmail.com>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Tom Talpey <tom@talpey.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-cifs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/4] smb/server: various clean-ups
Date: Mon, 9 Jun 2025 09:35:06 +1000 [thread overview]
Message-ID: <20250608234108.30250-1-neil@brown.name> (raw)
I am working towards making some changes to how locking is managed for
directory operations. Prior to attempting to land these changes I am
reviewing code that requests directory operations and cleaning up things
that might cause me problems later.
These 4 patches are the result of my review of smb/server. Note that
patch 3 fixes what appears to be a real deadlock that should be trivial
to hit if the client can actually set the flag which, as mentioned in
the patch, can trigger the deadlock.
Patch 1 is trivial but the others deserve careful review by someone who
knows the code. I think they are correct, but I've been wrong before.
Thanks,
NeilBrown
[PATCH 1/4] smb/server: use lookup_one_unlocked()
[PATCH 2/4] smb/server: simplify ksmbd_vfs_kern_path_locked()
[PATCH 3/4] smb/server: avoid deadlock when linking with
[PATCH 4/4] smb/server: add ksmbd_vfs_kern_path()
next reply other threads:[~2025-06-08 23:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-08 23:35 NeilBrown [this message]
2025-06-08 23:35 ` [PATCH 1/4] smb/server: use lookup_one_unlocked() NeilBrown
2025-06-08 23:35 ` [PATCH 2/4] smb/server: simplify ksmbd_vfs_kern_path_locked() NeilBrown
2025-06-08 23:35 ` [PATCH 3/4] smb/server: avoid deadlock when linking with ReplaceIfExists NeilBrown
2025-06-08 23:35 ` [PATCH 4/4] smb/server: add ksmbd_vfs_kern_path() NeilBrown
2025-07-23 15:36 ` Stefan Metzmacher
2025-07-23 23:03 ` NeilBrown
2025-07-23 23:19 ` Namjae Jeon
2025-07-16 5:22 ` [PATCH 0/4] smb/server: various clean-ups NeilBrown
2025-07-16 6:59 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250608234108.30250-1-neil@brown.name \
--to=neil@brown.name \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=senozhatsky@chromium.org \
--cc=smfrench@gmail.com \
--cc=tom@talpey.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).