From: Zhang Yi <yi.zhang@huaweicloud.com>
To: linux-ext4@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.cz,
ojaswin@linux.ibm.com, yi.zhang@huawei.com,
yi.zhang@huaweicloud.com, libaokun1@huawei.com,
yukuai3@huawei.com, yangerkun@huawei.com
Subject: [PATCH v2 0/6] ext4: fix insufficient credits when writing back large folios
Date: Wed, 11 Jun 2025 19:16:19 +0800 [thread overview]
Message-ID: <20250611111625.1668035-1-yi.zhang@huaweicloud.com> (raw)
From: Zhang Yi <yi.zhang@huawei.com>
Changes since v1:
- Make the write-back process supports writing a partial folio if it
exits the mapping loop prematurely due to insufficient sapce or
journal credits, it also fix the potential stale data and
inconsistency issues.
- Fix the same issue regarding the allocation of blocks in
ext4_write_begin() and ext4_page_mkwrite() when delalloc is not
enabled.
This series addresses the issue that Jan pointed out regarding large
folios support for ext4[1]. The problem is that the credits calculation
may insufficient in ext4_meta_trans_blocks() when allocating blocks
during write back a sufficiently large and discontinuous folio, it
doesn't involve the credits for updating bitmap and group descriptor
block. However, if we fix this issue, it may lead to significant
overestimation on the some filesystems with a lot of block groups.
The solution involves first ensure that the current journal transaction
has enough credits when we mapping an extent during allocating blocks.
Then if the credits reach the upper limit, exit the current mapping
loop, submit the partial folio and restart a new transaction. Finally,
fix the wrong credits calculation in ext4_meta_trans_blocks(). Please
see the following patches for details.
[1] https://lore.kernel.org/linux-ext4/ht54j6bvjmiqt62xmcveqlo7bmrunqs4ji7wikfteftdjijzek@7tz5gpejaoen/
Thanks,
Yi.
Zhang Yi (6):
ext4: move the calculation of wbc->nr_to_write to mpage_folio_done()
ext4: fix stale data if it bail out of the extents mapping loop
ext4: restart handle if credits are insufficient during allocating
blocks
ext4: correct the reserved credits for extent conversion
ext4/jbd2: reintroduce jbd2_journal_blocks_per_page()
ext4: fix insufficient credits calculation in ext4_meta_trans_blocks()
fs/ext4/ext4_jbd2.h | 7 +++
fs/ext4/inode.c | 118 ++++++++++++++++++++++++++++++++++++-------
fs/jbd2/journal.c | 6 +++
include/linux/jbd2.h | 1 +
4 files changed, 113 insertions(+), 19 deletions(-)
--
2.46.1
next reply other threads:[~2025-06-11 11:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 11:16 Zhang Yi [this message]
2025-06-11 11:16 ` [PATCH v2 1/6] ext4: move the calculation of wbc->nr_to_write to mpage_folio_done() Zhang Yi
2025-06-19 15:08 ` Jan Kara
2025-06-20 1:51 ` Baokun Li
2025-06-11 11:16 ` [PATCH v2 2/6] ext4: fix stale data if it bail out of the extents mapping loop Zhang Yi
2025-06-19 16:21 ` Jan Kara
2025-06-20 4:57 ` Zhang Yi
2025-06-20 15:21 ` Jan Kara
2025-06-21 4:42 ` Zhang Yi
2025-06-23 7:38 ` Jan Kara
2025-06-11 11:16 ` [PATCH v2 3/6] ext4: restart handle if credits are insufficient during allocating blocks Zhang Yi
2025-06-19 16:33 ` Jan Kara
2025-06-20 5:00 ` Zhang Yi
2025-06-20 14:18 ` Jan Kara
2025-06-21 6:30 ` Zhang Yi
2025-06-11 11:16 ` [PATCH v2 4/6] ext4: correct the reserved credits for extent conversion Zhang Yi
2025-06-23 8:12 ` Baokun Li
2025-06-11 11:16 ` [PATCH v2 5/6] ext4/jbd2: reintroduce jbd2_journal_blocks_per_page() Zhang Yi
2025-06-19 16:44 ` Jan Kara
2025-06-21 7:46 ` Zhang Yi
2025-06-23 7:26 ` Jan Kara
2025-06-11 11:16 ` [PATCH v2 6/6] ext4: fix insufficient credits calculation in ext4_meta_trans_blocks() Zhang Yi
2025-06-23 8:12 ` Baokun Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250611111625.1668035-1-yi.zhang@huaweicloud.com \
--to=yi.zhang@huaweicloud.com \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=libaokun1@huawei.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=tytso@mit.edu \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).