From: Al Viro <viro@zeniv.linux.org.uk>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Christian Brauner <brauner@kernel.org>,
Miklos Szeredi <miklos@szeredi.hu>, Jan Kara <jack@suse.cz>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/2] fs: constify file ptr in backing_file accessor helpers
Date: Wed, 11 Jun 2025 19:57:25 +0100 [thread overview]
Message-ID: <20250611185725.GQ299672@ZenIV> (raw)
In-Reply-To: <20250607115304.2521155-2-amir73il@gmail.com>
On Sat, Jun 07, 2025 at 01:53:03PM +0200, Amir Goldstein wrote:
> -struct path *backing_file_user_path(struct file *f)
> +struct path *backing_file_user_path(const struct file *f)
> {
> return &backing_file(f)->user_path;
> }
> EXPORT_SYMBOL_GPL(backing_file_user_path);
const struct path *, hopefully? With separate backing_file_set_user_path()
you shouldn't need to modify that struct path via that functions...
next prev parent reply other threads:[~2025-06-11 18:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-07 11:53 [PATCH 0/2] backing_file accessors cleanup Amir Goldstein
2025-06-07 11:53 ` [PATCH 1/2] fs: constify file ptr in backing_file accessor helpers Amir Goldstein
2025-06-11 18:57 ` Al Viro [this message]
2025-06-11 20:59 ` Amir Goldstein
2025-06-07 11:53 ` [PATCH 2/2] ovl: remove unneeded non-const conversion Amir Goldstein
2025-06-11 9:13 ` [PATCH 0/2] backing_file accessors cleanup Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250611185725.GQ299672@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).